STG77 GA APIView comments (Azure#19181)

* STG77 GA APIView comments * ci * changelog
AzureSDKAutomation · Jun 9, 2021 · 564e4c0 · 564e4c0
1 parent e1aa341
commit 564e4c0
Show file tree

Hide file tree

Showing 11 changed files with 23 additions and 14 deletions.
diff --git a/sdk/storage/azure-storage-file-datalake/CHANGELOG.md b/sdk/storage/azure-storage-file-datalake/CHANGELOG.md
@@ -1,5 +1,10 @@
 # Release History
 
+## 12.4.0 (2021-06-09)
+**New features**
+- Added support `set_service_properties()`,`get_service_properties()` on `DataLakeServiceClient`
+- Added support for `list_deleted_paths()` on `FileSystemClient`
+
 ## 12.4.0b1 (2021-05-12)
 **New features**
 - Added support `set_service_properties()`,`get_service_properties()` on `DataLakeServiceClient`

diff --git a/sdk/storage/azure-storage-file-datalake/azure/storage/filedatalake/_file_system_client.py b/sdk/storage/azure-storage-file-datalake/azure/storage/filedatalake/_file_system_client.py
@@ -895,7 +895,7 @@ def list_deleted_paths(self, **kwargs):
 
         :keyword str path_prefix:
             Filters the results to return only paths under the specified path.
-        :keyword int max_results:
+        :keyword int results_per_page:
             An optional value that specifies the maximum number of items to return per page.
             If omitted or greater than 5,000, the response will include up to 5,000 items per page.
         :keyword int timeout:
@@ -905,8 +905,8 @@ def list_deleted_paths(self, **kwargs):
             ~azure.core.paging.ItemPaged[~azure.storage.filedatalake.DeletedPathProperties]
         """
         path_prefix = kwargs.pop('path_prefix', None)
-        results_per_page = kwargs.pop('max_results', None)
         timeout = kwargs.pop('timeout', None)
+        results_per_page = kwargs.pop('results_per_page', None)
         command = functools.partial(
             self._datalake_client_for_blob_operation.file_system.list_blob_hierarchy_segment,
             showonly=ListBlobsIncludeItem.deleted,

diff --git a/sdk/storage/azure-storage-file-datalake/azure/storage/filedatalake/_version.py b/sdk/storage/azure-storage-file-datalake/azure/storage/filedatalake/_version.py
@@ -4,4 +4,4 @@
 # license information.
 # --------------------------------------------------------------------------
 
-VERSION = "12.4.0b1"
+VERSION = "12.4.0"
diff --git a/...e/azure-storage-file-datalake/azure/storage/filedatalake/aio/_file_system_client_async.py b/...e/azure-storage-file-datalake/azure/storage/filedatalake/aio/_file_system_client_async.py
@@ -845,7 +845,7 @@ def list_deleted_paths(self, **kwargs):
 
         :keyword str path_prefix:
             Filters the results to return only paths under the specified path.
-        :keyword int max_results:
+        :keyword int results_per_page:
             An optional value that specifies the maximum number of items to return per page.
             If omitted or greater than 5,000, the response will include up to 5,000 items per page.
         :keyword int timeout:
@@ -855,8 +855,8 @@ def list_deleted_paths(self, **kwargs):
             ~azure.core.paging.AsyncItemPaged[~azure.storage.filedatalake.DeletedPathProperties]
         """
         path_prefix = kwargs.pop('path_prefix', None)
-        results_per_page = kwargs.pop('max_results', None)
         timeout = kwargs.pop('timeout', None)
+        results_per_page = kwargs.pop('results_per_page', None)
         command = functools.partial(
             self._datalake_client_for_blob_operation.file_system.list_blob_hierarchy_segment,
             showonly=ListBlobsIncludeItem.deleted,

diff --git a/sdk/storage/azure-storage-file-datalake/setup.py b/sdk/storage/azure-storage-file-datalake/setup.py
@@ -73,7 +73,7 @@
     author_email='ascl@microsoft.com',
     url='https://github.com/Azure/azure-sdk-for-python',
     classifiers=[
-        "Development Status :: 4 - Beta",
+        "Development Status :: 5 - Production/Stable",
         'Programming Language :: Python',
         'Programming Language :: Python :: 2',
         'Programming Language :: Python :: 2.7',

diff --git a/sdk/storage/azure-storage-file-datalake/tests/test_file_system.py b/sdk/storage/azure-storage-file-datalake/tests/test_file_system.py
@@ -447,10 +447,10 @@ def test_get_deleted_paths(self, datalake_storage_account_name, datalake_storage
         self.assertEqual(dir3_paths[0].name, 'dir3/file_in_dir3')
         self.assertEqual(dir3_paths[1].name, 'dir3/subdir/file_in_subdir')
 
-        paths_generator1 = file_system.list_deleted_paths(max_results=2).by_page()
+        paths_generator1 = file_system.list_deleted_paths(results_per_page=2).by_page()
         paths1 = list(next(paths_generator1))
 
-        paths_generator2 = file_system.list_deleted_paths(max_results=4).by_page(
+        paths_generator2 = file_system.list_deleted_paths(results_per_page=4).by_page(
             continuation_token=paths_generator1.continuation_token)
         paths2 = list(next(paths_generator2))
 

diff --git a/sdk/storage/azure-storage-file-datalake/tests/test_file_system_async.py b/sdk/storage/azure-storage-file-datalake/tests/test_file_system_async.py
@@ -611,12 +611,12 @@ async def test_get_deleted_paths(self, datalake_storage_account_name, datalake_s
         self.assertEqual(dir3_paths[0].name, 'dir3/file_in_dir3')
         self.assertEqual(dir3_paths[1].name, 'dir3/subdir/file_in_subdir')
 
-        paths_generator1 = file_system.list_deleted_paths(max_results=2).by_page()
+        paths_generator1 = file_system.list_deleted_paths(results_per_page=2).by_page()
         paths1 = []
         async for path in await paths_generator1.__anext__():
             paths1.append(path)
 
-        paths_generator2 = file_system.list_deleted_paths(max_results=4) \
+        paths_generator2 = file_system.list_deleted_paths(results_per_page=4) \
             .by_page(continuation_token=paths_generator1.continuation_token)
         paths2 = []
         async for path in await paths_generator2.__anext__():

diff --git a/sdk/storage/azure-storage-file-share/CHANGELOG.md b/sdk/storage/azure-storage-file-share/CHANGELOG.md
@@ -1,5 +1,9 @@
 # Release History
 
+## 12.5.0 (2021-06-09)
+**New features**
+- Added support for lease operation on a share, eg. acquire_lease
+
 ## 12.5.0b1 (2021-05-12)
 **New features**
 - Added support for lease operation on a share, eg. acquire_lease

diff --git a/sdk/storage/azure-storage-file-share/azure/storage/fileshare/_share_client.py b/sdk/storage/azure-storage-file-share/azure/storage/fileshare/_share_client.py
@@ -278,12 +278,12 @@ def acquire_lease(self, **kwargs):
 
         .. versionadded:: 12.5.0
 
-        :kwarg int lease_duration:
+        :keyword int lease_duration:
             Specifies the duration of the lease, in seconds, or negative one
             (-1) for a lease that never expires. A non-infinite lease can be
             between 15 and 60 seconds. A lease duration cannot be changed
             using renew or change. Default is -1 (infinite lease).
-        :kwarg str lease_id:
+        :keyword str lease_id:
             Proposed lease ID, in a GUID string format. The Share Service
             returns 400 (Invalid request) if the proposed lease ID is not
             in the correct format.

diff --git a/sdk/storage/azure-storage-file-share/azure/storage/fileshare/_version.py b/sdk/storage/azure-storage-file-share/azure/storage/fileshare/_version.py
@@ -4,4 +4,4 @@
 # license information.
 # --------------------------------------------------------------------------
 
-VERSION = "12.5.0b1"
+VERSION = "12.5.0"
diff --git a/sdk/storage/azure-storage-file-share/setup.py b/sdk/storage/azure-storage-file-share/setup.py
@@ -59,7 +59,7 @@
     author_email='ascl@microsoft.com',
     url='https://github.com/Azure/azure-sdk-for-python/tree/master/sdk/storage/azure-storage-file-share',
     classifiers=[
-        "Development Status :: 4 - Beta",
+        "Development Status :: 5 - Production/Stable",
         'Programming Language :: Python',
         'Programming Language :: Python :: 2',
         'Programming Language :: Python :: 2.7',