Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AutoPR track2_@azure/arm-compute] PIR and SIG architecture #7624

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions common/config/rush/pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

13 changes: 13 additions & 0 deletions sdk/compute/arm-compute/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,18 @@
# Release History

## 17.3.0 (2022-02-25)

**Features**

- Added Type Alias Architecture
- Added Type Alias ArchitectureTypes
- Type Alias GalleryImage has a new parameter architecture
- Type Alias GalleryImageUpdate has a new parameter architecture
- Type Alias VirtualMachineImage has a new parameter architecture
- Added Enum KnownArchitecture
- Added Enum KnownArchitectureTypes


## 17.2.0 (2022-02-14)

**Features**
Expand Down
6 changes: 3 additions & 3 deletions sdk/compute/arm-compute/_meta.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"commit": "7c98de7664d4565c088350015ccd0cfc102eab49",
"commit": "f3a4e2ab6f8d34b24063e7c56e1e3a7b770630d1",
"readme": "specification/compute/resource-manager/readme.md",
"autorest_command": "autorest --version=3.7.3 --typescript --modelerfour.lenient-model-deduplication --head-as-boolean=true --license-header=MICROSOFT_MIT_NO_VERSION --generate-test --typescript-sdks-folder=D:\\mydev\\azure-sdk-for-js ../azure-rest-api-specs/specification/compute/resource-manager/readme.md --use=@autorest/typescript@6.0.0-alpha.16.20220128.1 --generate-sample=true",
"autorest_command": "autorest --version=3.7.3 --typescript --modelerfour.lenient-model-deduplication --head-as-boolean=true --license-header=MICROSOFT_MIT_NO_VERSION --generate-test --typescript-sdks-folder=/home/vsts/work/1/s/azure-sdk-for-js ../azure-rest-api-specs/specification/compute/resource-manager/readme.md --use=@autorest/typescript@6.0.0-alpha.16.20220105.1",
"repository_url": "https://github.com/Azure/azure-rest-api-specs.git",
"use": "@autorest/typescript@6.0.0-alpha.16.20220128.1"
"use": "@autorest/typescript@6.0.0-alpha.16.20220105.1"
}
23 changes: 3 additions & 20 deletions sdk/compute/arm-compute/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"sdk-type": "mgmt",
"author": "Microsoft Corporation",
"description": "A generated SDK for ComputeManagementClient.",
"version": "17.2.0",
"version": "1.0.0-beta.1",
"engines": {
"node": ">=12.0.0"
},
Expand Down Expand Up @@ -42,8 +42,7 @@
"@azure/identity": "^2.0.1",
"@azure-tools/test-recorder": "^1.0.0",
"mocha": "^7.1.1",
"cross-env": "^7.0.2",
"@azure/arm-network": "^26.0.0"
"cross-env": "^7.0.2"
},
"homepage": "https://github.com/Azure/azure-sdk-for-js/tree/main/sdk/compute/arm-compute",
"repository": {
Expand Down Expand Up @@ -99,21 +98,5 @@
"docs": "echo skipped"
},
"sideEffects": false,
"//metadata": {
"constantPaths": [
{
"path": "src/computeManagementClient.ts",
"prefix": "packageDetails"
}
]
},
"autoPublish": true,
"//sampleConfiguration": {
"productName": "",
"productSlugs": [
"azure"
],
"disableDocsMs": true,
"apiRefLink": "https://docs.microsoft.com/javascript/api/@azure/arm-compute?view=azure-node-preview"
}
"autoPublish": true
}
25 changes: 25 additions & 0 deletions sdk/compute/arm-compute/review/arm-compute.api.md
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,12 @@ export interface ApplicationProfile {
galleryApplications?: VMGalleryApplication[];
}

// @public
export type Architecture = string;

// @public
export type ArchitectureTypes = string;

// @public
export interface AutomaticOSUpgradePolicy {
disableAutomaticRollback?: boolean;
Expand Down Expand Up @@ -2345,6 +2351,7 @@ export type GalleryImage = Resource & {
purchasePlan?: ImagePurchasePlan;
readonly provisioningState?: GalleryImagePropertiesProvisioningState;
features?: GalleryImageFeature[];
architecture?: Architecture;
};

// @public
Expand Down Expand Up @@ -2442,6 +2449,7 @@ export type GalleryImageUpdate = UpdateResourceDefinition & {
purchasePlan?: ImagePurchasePlan;
readonly provisioningState?: GalleryImagePropertiesProvisioningState;
features?: GalleryImageFeature[];
architecture?: Architecture;
};

// @public
Expand Down Expand Up @@ -2852,6 +2860,22 @@ export enum KnownAggregatedReplicationState {
Unknown = "Unknown"
}

// @public
export enum KnownArchitecture {
// (undocumented)
Arm64 = "Arm64",
// (undocumented)
X64 = "x64"
}

// @public
export enum KnownArchitectureTypes {
// (undocumented)
Arm64 = "Arm64",
// (undocumented)
X64 = "x64"
}

// @public
export enum KnownAvailabilitySetSkuTypes {
// (undocumented)
Expand Down Expand Up @@ -5961,6 +5985,7 @@ export type VirtualMachineImage = VirtualMachineImageResource & {
hyperVGeneration?: HyperVGenerationTypes;
disallowed?: DisallowedConfiguration;
features?: VirtualMachineImageFeature[];
architecture?: ArchitectureTypes;
};

// @public
Expand Down
2 changes: 1 addition & 1 deletion sdk/compute/arm-compute/src/computeManagementClient.ts
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ export class ComputeManagementClient extends coreClient.ServiceClient {
credential: credentials
};

const packageDetails = `azsdk-js-arm-compute/17.2.0`;
const packageDetails = `azsdk-js-arm-compute/17.3.0`;
const userAgentPrefix =
options.userAgentOptions && options.userAgentOptions.userAgentPrefix
? `${options.userAgentOptions.userAgentPrefix} ${packageDetails}`
Expand Down
38 changes: 38 additions & 0 deletions sdk/compute/arm-compute/src/models/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5090,6 +5090,8 @@ export type GalleryImage = Resource & {
readonly provisioningState?: GalleryImagePropertiesProvisioningState;
/** A list of gallery image features. */
features?: GalleryImageFeature[];
/** The architecture of the image. Applicable to OS disks only. */
architecture?: Architecture;
};

/** Specifies information about the gallery image version that you want to create or update. */
Expand Down Expand Up @@ -5830,6 +5832,8 @@ export type GalleryImageUpdate = UpdateResourceDefinition & {
readonly provisioningState?: GalleryImagePropertiesProvisioningState;
/** A list of gallery image features. */
features?: GalleryImageFeature[];
/** The architecture of the image. Applicable to OS disks only. */
architecture?: Architecture;
};

/** Specifies information about the gallery image version that you want to update. */
Expand Down Expand Up @@ -5968,6 +5972,8 @@ export type VirtualMachineImage = VirtualMachineImageResource & {
/** Specifies disallowed configuration for the VirtualMachine created from the image */
disallowed?: DisallowedConfiguration;
features?: VirtualMachineImageFeature[];
/** Specifies the Architecture Type */
architecture?: ArchitectureTypes;
};

/** Describes a Virtual Machine Scale Set VM Reimage Parameters. */
Expand Down Expand Up @@ -6057,6 +6063,22 @@ export enum KnownVmDiskTypes {
*/
export type VmDiskTypes = string;

/** Known values of {@link ArchitectureTypes} that the service accepts. */
export enum KnownArchitectureTypes {
X64 = "x64",
Arm64 = "Arm64"
}

/**
* Defines values for ArchitectureTypes. \
* {@link KnownArchitectureTypes} can be used interchangeably with ArchitectureTypes,
* this enum contains the known values that the service supports.
* ### Known values supported by the service
* **x64** \
* **Arm64**
*/
export type ArchitectureTypes = string;

/** Known values of {@link ExtendedLocationTypes} that the service accepts. */
export enum KnownExtendedLocationTypes {
EdgeZone = "EdgeZone"
Expand Down Expand Up @@ -7659,6 +7681,22 @@ export enum KnownGalleryImagePropertiesProvisioningState {
*/
export type GalleryImagePropertiesProvisioningState = string;

/** Known values of {@link Architecture} that the service accepts. */
export enum KnownArchitecture {
X64 = "x64",
Arm64 = "Arm64"
}

/**
* Defines values for Architecture. \
* {@link KnownArchitecture} can be used interchangeably with Architecture,
* this enum contains the known values that the service supports.
* ### Known values supported by the service
* **x64** \
* **Arm64**
*/
export type Architecture = string;

/** Known values of {@link StorageAccountType} that the service accepts. */
export enum KnownStorageAccountType {
StandardLRS = "Standard_LRS",
Expand Down
18 changes: 18 additions & 0 deletions sdk/compute/arm-compute/src/models/mappers.ts
Original file line number Diff line number Diff line change
Expand Up @@ -13147,6 +13147,12 @@ export const GalleryImage: coreClient.CompositeMapper = {
}
}
}
},
architecture: {
serializedName: "properties.architecture",
type: {
name: "String"
}
}
}
}
Expand Down Expand Up @@ -15030,6 +15036,12 @@ export const GalleryImageUpdate: coreClient.CompositeMapper = {
}
}
}
},
architecture: {
serializedName: "properties.architecture",
type: {
name: "String"
}
}
}
}
Expand Down Expand Up @@ -15439,6 +15451,12 @@ export const VirtualMachineImage: coreClient.CompositeMapper = {
}
}
}
},
architecture: {
serializedName: "properties.architecture",
type: {
name: "String"
}
}
}
}
Expand Down
48 changes: 48 additions & 0 deletions sdk/compute/arm-compute/test/sampleTest.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,48 @@
/*
* Copyright (c) Microsoft Corporation.
* Licensed under the MIT License.
*
* Code generated by Microsoft (R) AutoRest Code Generator.
* Changes may cause incorrect behavior and will be lost if the code is regenerated.
*/

import {
env,
record,
RecorderEnvironmentSetup,
Recorder
} from "@azure-tools/test-recorder";
import * as assert from "assert";

const recorderEnvSetup: RecorderEnvironmentSetup = {
replaceableVariables: {
AZURE_CLIENT_ID: "azure_client_id",
AZURE_CLIENT_SECRET: "azure_client_secret",
AZURE_TENANT_ID: "88888888-8888-8888-8888-888888888888",
SUBSCRIPTION_ID: "azure_subscription_id"
},
customizationsOnRecordings: [
(recording: any): any =>
recording.replace(
/"access_token":"[^"]*"/g,
`"access_token":"access_token"`
)
],
queryParametersToSkip: []
};

describe("My test", () => {
let recorder: Recorder;

beforeEach(async function() {
recorder = record(this, recorderEnvSetup);
});

afterEach(async function() {
await recorder.stop();
});

it("sample test", async function() {
console.log("Hi, I'm a test!");
});
});
7 changes: 1 addition & 6 deletions sdk/compute/arm-compute/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,7 @@
],
"declaration": true,
"outDir": "./dist-esm",
"importHelpers": true,
"paths": {
"@azure/arm-compute": [
"./src/index"
]
}
"importHelpers": true
},
"include": [
"./src/**/*.ts",
Expand Down