CodeGen from PR 15308 in Azure/azure-rest-api-specs

Merge 59004149c41d53f1d7866d57e5440c13b3822015 into 4d61f9054ca7678ebf596e66c4f6300a21043970

sdk/servicefabric/servicefabric/LICENSE.txt

@@ -1,6 +1,6 @@
 The MIT License (MIT)
 
-Copyright (c) 2019 Microsoft
+Copyright (c) 2021 Microsoft
 
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal

sdk/servicefabric/servicefabric/README.md

@@ -1,84 +1,98 @@
 ## An isomorphic javascript sdk for - ServiceFabricClient
 
-This package contains an isomorphic SDK for ServiceFabricClient.
+This package contains an isomorphic SDK (runs both in node.js and in browsers) for ServiceFabricClient.
 
 ### Currently supported environments
 
-- Node.js version 6.x.x or higher
-- Browser JavaScript
+- [LTS versions of Node.js](https://nodejs.org/about/releases/)
+- Latest versions of Safari, Chrome, Edge and Firefox.
 
-### How to Install
+### Prerequisites
 
+You must have an [Azure subscription](https://azure.microsoft.com/free/).
+
+### How to install
+
+To use this SDK in your project, you will need to install two packages.
+- `@azure/servicefabric` that contains the client.
+- `@azure/identity` that provides different mechanisms for the client to authenticate your requests using Azure Active Directory.
+
+Install both packages using the below command:
 ```bash
-npm install @azure/servicefabric
+npm install --save @azure/servicefabric @azure/identity
 ```
+> **Note**: You may have used either `@azure/ms-rest-nodeauth` or `@azure/ms-rest-browserauth` in the past. These packages are in maintenance mode receiving critical bug fixes, but no new features.
+If you are on a [Node.js that has LTS status](https://nodejs.org/about/releases/), or are writing a client side browser application, we strongly encourage you to upgrade to `@azure/identity` which uses the latest versions of Azure Active Directory and MSAL APIs and provides more authentication options.
 
 ### How to use
 
-#### nodejs - Authentication, client creation and getClusterManifest as an example written in TypeScript.
-
-##### Install @azure/ms-rest-nodeauth
+- If you are writing a client side browser application,
+  - Follow the instructions in the section on Authenticating client side browser applications in [Azure Identity examples](https://aka.ms/azsdk/js/identity/examples) to register your application in the Microsoft identity platform and set the right permissions.
+  - Copy the client ID and tenant ID from the Overview section of your app registration in Azure portal and use it in the browser sample below.
+- If you are writing a server side application,
+  - [Select a credential from `@azure/identity` based on the authentication method of your choice](https://aka.ms/azsdk/js/identity/examples)
+  - Complete the set up steps required by the credential if any.
+  - Use the credential you picked in the place of `DefaultAzureCredential` in the Node.js sample below.
 
-- Please install minimum version of `"@azure/ms-rest-nodeauth": "^3.0.0"`.
-
-```bash
-npm install @azure/ms-rest-nodeauth@"^3.0.0"
-```
+In the below samples, we pass the credential and the Azure subscription id to instantiate the client.
+Once the client is created, explore the operations on it either in your favorite editor or in our [API reference documentation](https://docs.microsoft.com/javascript/api) to get started.
+#### nodejs - Authentication, client creation, and getClusterManifest  as an example written in JavaScript.
 
 ##### Sample code
 
-[Service Fabric cluster security scenarios](https://docs.microsoft.com/azure/service-fabric/service-fabric-cluster-security)
-
-```typescript
-import { ServiceFabricClient } from "@azure/servicefabric";
-const baseUri = "<ServiceFabricURL>:<connection-port>";
-const client = new ServiceFabricClient({
-  baseUri
+```javascript
+const { DefaultAzureCredential } = require("@azure/identity");
+const { ServiceFabricClient } = require("@azure/servicefabric");
+const subscriptionId = process.env["AZURE_SUBSCRIPTION_ID"];
+
+// Use `DefaultAzureCredential` or any other credential of your choice based on https://aka.ms/azsdk/js/identity/examples
+// Please note that you can also use credentials from the `@azure/ms-rest-nodeauth` package instead.
+const creds = new DefaultAzureCredential();
+const client = new ServiceFabricClient(creds, subscriptionId);
+const timeout = 1;
+client.getClusterManifest(timeout).then((result) => {
+  console.log("The result is:");
+  console.log(result);
+}).catch((err) => {
+  console.log("An error occurred:");
+  console.error(err);
 });
-client
-  .getClusterManifest()
-  .then((result) => {
-    console.log(result.manifest);
-  })
-  .catch(console.error);
 ```
 
-#### browser - Authentication, client creation and getClusterManifest as an example written in JavaScript.
-
-##### Install @azure/ms-rest-browserauth
+#### browser - Authentication, client creation, and getClusterManifest  as an example written in JavaScript.
 
-```bash
-npm install @azure/ms-rest-browserauth
-```
+In browser applications, we recommend using the `InteractiveBrowserCredential` that interactively authenticates using the default system browser.
+  - See [Single-page application: App registration guide](https://docs.microsoft.com/azure/active-directory/develop/scenario-spa-app-registration) to configure your app registration for the browser.
+  - Note down the client Id from the previous step and use it in the browser sample below.
 
 ##### Sample code
 
-See https://github.com/Azure/ms-rest-browserauth to learn how to authenticate to Azure in the browser.
-
 - index.html
 
 ```html
 <!DOCTYPE html>
 <html lang="en">
   <head>
     <title>@azure/servicefabric sample</title>
-    <script src="node_modules/@azure/ms-rest-js/dist/msRest.browser.js"></script>
     <script src="node_modules/@azure/servicefabric/dist/servicefabric.js"></script>
     <script type="text/javascript">
-      var baseUri = "<ServiceFabricURL>:<connection-port>";
-      var client = new Azure.Servicefabric.ServiceFabricClient({
-        baseUri
+      const subscriptionId = "<Subscription_Id>";
+      // Create credentials using the `@azure/identity` package.
+      // Please note that you can also use credentials from the `@azure/ms-rest-browserauth` package instead.
+      const credential = new InteractiveBrowserCredential(
+      {
+        clientId: "<client id for your Azure AD app>",
+        tenant: "<optional tenant for your organization>"
+      });
+      const client = new Azure.Servicefabric.ServiceFabricClient(creds, subscriptionId);
+      const timeout = 1;
+      client.getClusterManifest(timeout).then((result) => {
+        console.log("The result is:");
+        console.log(result);
+      }).catch((err) => {
+        console.log("An error occurred:");
+        console.error(err);
       });
-      client
-        .getClusterManifest()
-        .then((result) => {
-          console.log("The result is:");
-          console.log(result);
-        })
-        .catch((err) => {
-          console.log("An error occurred:");
-          console.error(err);
-        });
     </script>
   </head>
   <body></body>

sdk/servicefabric/servicefabric/package.json

@@ -4,7 +4,8 @@
   "description": "ServiceFabricClient Library with typescript type definitions for node.js and browser.",
   "version": "5.0.0",
   "dependencies": {
-    "@azure/ms-rest-js": "^2.0.4",
+    "@azure/ms-rest-js": "^2.2.0",
+    "@azure/core-auth": "^1.1.4",
     "tslib": "^1.10.0"
   },
   "keywords": [
@@ -19,13 +20,13 @@
   "module": "./esm/serviceFabricClient.js",
   "types": "./esm/serviceFabricClient.d.ts",
   "devDependencies": {
-    "typescript": "^3.5.3",
+    "typescript": "^3.6.0",
     "rollup": "^1.18.0",
     "rollup-plugin-node-resolve": "^5.2.0",
     "rollup-plugin-sourcemaps": "^0.4.2",
     "uglify-js": "^3.6.0"
   },
-  "homepage": "https://github.com/Azure/azure-sdk-for-js/tree/main/sdk/servicefabric/servicefabric",
+  "homepage": "https://github.com/Azure/azure-sdk-for-js/tree/master/sdk/servicefabric/servicefabric",
   "repository": {
     "type": "git",
     "url": "https://github.com/Azure/azure-sdk-for-js.git"

sdk/servicefabric/servicefabric/rollup.config.js

@@ -21,8 +21,8 @@ const config = {
       "@azure/ms-rest-azure-js": "msRestAzure"
     },
     banner: `/*
- * Copyright (c) Microsoft Corporation. All rights reserved.
- * Licensed under the MIT License. See License.txt in the project root for license information.
+ * Copyright (c) Microsoft Corporation.
+ * Licensed under the MIT License.
  *
  * Code generated by Microsoft (R) AutoRest Code Generator.
  * Changes may cause incorrect behavior and will be lost if the code is regenerated.