Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AutoPR azure-resourcemanager-webpubsub] Fix swagger correctness: secrets were wrongfully marked as write-only #11949

Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
CodeGen from PR 17228 in Azure/azure-rest-api-specs
Merge 0b01cf5d9d287887dda363edb45c8b7dab1ddc74 into 46a7b5a0061dfe2ec327461f664532f8939355f7
  • Loading branch information
SDKAuto committed Jan 6, 2022
commit fa98001ee58c08b9a21f799e30c196fcfc587092
4 changes: 3 additions & 1 deletion sdk/webpubsub/azure-resourcemanager-webpubsub/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
# Release History

## 1.0.0-beta.3 (Unreleased)
## 1.0.0-beta.1 (2022-01-06)

- Azure Resource Manager WebPubSub client library for Java. This package contains Microsoft Azure SDK for WebPubSub Management SDK. REST API for Azure WebPubSub Service. Package tag package-2021-10-01. For documentation on how to use this package, please see [Azure Management Libraries for Java](https://aka.ms/azsdk/java/mgmt).

### Features Added

Expand Down
2 changes: 1 addition & 1 deletion sdk/webpubsub/azure-resourcemanager-webpubsub/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ Various documentation is available to help you get started
<dependency>
<groupId>com.azure.resourcemanager</groupId>
<artifactId>azure-resourcemanager-webpubsub</artifactId>
<version>1.0.0-beta.2</version>
<version>1.0.0-beta.3</version>
</dependency>
```
[//]: # ({x-version-update-end})
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
import com.azure.core.http.HttpClient;
import com.azure.core.http.HttpPipeline;
import com.azure.core.http.HttpPipelineBuilder;
import com.azure.core.http.HttpPipelinePosition;
import com.azure.core.http.policy.AddDatePolicy;
import com.azure.core.http.policy.HttpLogOptions;
import com.azure.core.http.policy.HttpLoggingPolicy;
Expand Down Expand Up @@ -41,6 +42,7 @@
import java.util.ArrayList;
import java.util.List;
import java.util.Objects;
import java.util.stream.Collectors;

/** Entry point to WebPubSubManager. REST API for Azure WebPubSub Service. */
public final class WebPubSubManager {
Expand Down Expand Up @@ -194,7 +196,7 @@ public WebPubSubManager authenticate(TokenCredential credential, AzureProfile pr
.append("-")
.append("com.azure.resourcemanager.webpubsub")
.append("/")
.append("1.0.0-beta.2");
.append("1.0.0-beta.1");
if (!Configuration.getGlobalConfiguration().get("AZURE_TELEMETRY_DISABLED", false)) {
userAgentBuilder
.append(" (")
Expand All @@ -217,11 +219,24 @@ public WebPubSubManager authenticate(TokenCredential credential, AzureProfile pr
List<HttpPipelinePolicy> policies = new ArrayList<>();
policies.add(new UserAgentPolicy(userAgentBuilder.toString()));
policies.add(new RequestIdPolicy());
policies
.addAll(
this
.policies
.stream()
.filter(p -> p.getPipelinePosition() == HttpPipelinePosition.PER_CALL)
.collect(Collectors.toList()));
HttpPolicyProviders.addBeforeRetryPolicies(policies);
policies.add(retryPolicy);
policies.add(new AddDatePolicy());
policies.add(new ArmChallengeAuthenticationPolicy(credential, scopes.toArray(new String[0])));
policies.addAll(this.policies);
policies
.addAll(
this
.policies
.stream()
.filter(p -> p.getPipelinePosition() == HttpPipelinePosition.PER_RETRY)
.collect(Collectors.toList()));
HttpPolicyProviders.addAfterRetryPolicies(policies);
policies.add(new HttpLoggingPolicy(httpLogOptions));
HttpPipeline httpPipeline =
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ public final class OperationInner {
private Boolean isDataAction;

/*
* The object that describes the operation.
* The object that describes a operation.
*/
@JsonProperty(value = "display")
private OperationDisplay display;
Expand All @@ -42,7 +42,7 @@ public final class OperationInner {
private String origin;

/*
* Extra properties for the operation.
* Extra Operation properties.
*/
@JsonProperty(value = "properties")
private OperationProperties properties;
Expand Down Expand Up @@ -88,7 +88,7 @@ public OperationInner withIsDataAction(Boolean isDataAction) {
}

/**
* Get the display property: The object that describes the operation.
* Get the display property: The object that describes a operation.
*
* @return the display value.
*/
Expand All @@ -97,7 +97,7 @@ public OperationDisplay display() {
}

/**
* Set the display property: The object that describes the operation.
* Set the display property: The object that describes a operation.
*
* @param display the display value to set.
* @return the OperationInner object itself.
Expand Down Expand Up @@ -130,7 +130,7 @@ public OperationInner withOrigin(String origin) {
}

/**
* Get the properties property: Extra properties for the operation.
* Get the properties property: Extra Operation properties.
*
* @return the properties value.
*/
Expand All @@ -139,7 +139,7 @@ public OperationProperties properties() {
}

/**
* Set the properties property: Extra properties for the operation.
* Set the properties property: Extra Operation properties.
*
* @param properties the properties value to set.
* @return the OperationInner object itself.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ public final class PrivateEndpointConnectionInner extends ProxyResource {
private SystemData systemData;

/*
* Properties of the private endpoint connection
* Private endpoint connection properties
*/
@JsonProperty(value = "properties")
private PrivateEndpointConnectionProperties innerProperties;
Expand All @@ -42,7 +42,7 @@ public SystemData systemData() {
}

/**
* Get the innerProperties property: Properties of the private endpoint connection.
* Get the innerProperties property: Private endpoint connection properties.
*
* @return the innerProperties value.
*/
Expand All @@ -51,7 +51,7 @@ private PrivateEndpointConnectionProperties innerProperties() {
}

/**
* Get the provisioningState property: Provisioning state of the private endpoint connection.
* Get the provisioningState property: Provisioning state of the resource.
*
* @return the provisioningState value.
*/
Expand All @@ -60,7 +60,7 @@ public ProvisioningState provisioningState() {
}

/**
* Get the privateEndpoint property: Private endpoint associated with the private endpoint connection.
* Get the privateEndpoint property: Private endpoint.
*
* @return the privateEndpoint value.
*/
Expand All @@ -69,7 +69,7 @@ public PrivateEndpoint privateEndpoint() {
}

/**
* Set the privateEndpoint property: Private endpoint associated with the private endpoint connection.
* Set the privateEndpoint property: Private endpoint.
*
* @param privateEndpoint the privateEndpoint value to set.
* @return the PrivateEndpointConnectionInner object itself.
Expand All @@ -92,7 +92,7 @@ public List<String> groupIds() {
}

/**
* Get the privateLinkServiceConnectionState property: Connection state.
* Get the privateLinkServiceConnectionState property: Connection state of the private endpoint connection.
*
* @return the privateLinkServiceConnectionState value.
*/
Expand All @@ -101,7 +101,7 @@ public PrivateLinkServiceConnectionState privateLinkServiceConnectionState() {
}

/**
* Set the privateLinkServiceConnectionState property: Connection state.
* Set the privateLinkServiceConnectionState property: Connection state of the private endpoint connection.
*
* @param privateLinkServiceConnectionState the privateLinkServiceConnectionState value to set.
* @return the PrivateEndpointConnectionInner object itself.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,13 +19,13 @@ public final class PrivateEndpointConnectionProperties {
@JsonIgnore private final ClientLogger logger = new ClientLogger(PrivateEndpointConnectionProperties.class);

/*
* Provisioning state of the private endpoint connection
* Provisioning state of the resource.
*/
@JsonProperty(value = "provisioningState", access = JsonProperty.Access.WRITE_ONLY)
private ProvisioningState provisioningState;

/*
* Private endpoint associated with the private endpoint connection
* Private endpoint
*/
@JsonProperty(value = "privateEndpoint")
private PrivateEndpoint privateEndpoint;
Expand All @@ -37,13 +37,13 @@ public final class PrivateEndpointConnectionProperties {
private List<String> groupIds;

/*
* Connection state
* Connection state of the private endpoint connection
*/
@JsonProperty(value = "privateLinkServiceConnectionState")
private PrivateLinkServiceConnectionState privateLinkServiceConnectionState;

/**
* Get the provisioningState property: Provisioning state of the private endpoint connection.
* Get the provisioningState property: Provisioning state of the resource.
*
* @return the provisioningState value.
*/
Expand All @@ -52,7 +52,7 @@ public ProvisioningState provisioningState() {
}

/**
* Get the privateEndpoint property: Private endpoint associated with the private endpoint connection.
* Get the privateEndpoint property: Private endpoint.
*
* @return the privateEndpoint value.
*/
Expand All @@ -61,7 +61,7 @@ public PrivateEndpoint privateEndpoint() {
}

/**
* Set the privateEndpoint property: Private endpoint associated with the private endpoint connection.
* Set the privateEndpoint property: Private endpoint.
*
* @param privateEndpoint the privateEndpoint value to set.
* @return the PrivateEndpointConnectionProperties object itself.
Expand All @@ -81,7 +81,7 @@ public List<String> groupIds() {
}

/**
* Get the privateLinkServiceConnectionState property: Connection state.
* Get the privateLinkServiceConnectionState property: Connection state of the private endpoint connection.
*
* @return the privateLinkServiceConnectionState value.
*/
Expand All @@ -90,7 +90,7 @@ public PrivateLinkServiceConnectionState privateLinkServiceConnectionState() {
}

/**
* Set the privateLinkServiceConnectionState property: Connection state.
* Set the privateLinkServiceConnectionState property: Connection state of the private endpoint connection.
*
* @param privateLinkServiceConnectionState the privateLinkServiceConnectionState value to set.
* @return the PrivateEndpointConnectionProperties object itself.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,13 +18,13 @@ public final class PrivateLinkResourceInner extends ProxyResource {
@JsonIgnore private final ClientLogger logger = new ClientLogger(PrivateLinkResourceInner.class);

/*
* Properties of a private link resource
* Private link resource properties
*/
@JsonProperty(value = "properties")
private PrivateLinkResourceProperties innerProperties;

/**
* Get the innerProperties property: Properties of a private link resource.
* Get the innerProperties property: Private link resource properties.
*
* @return the innerProperties value.
*/
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ public final class SharedPrivateLinkResourceInner extends ProxyResource {
private SystemData systemData;

/*
* Describes the properties of a Shared Private Link Resource
* Describes the properties of an existing Shared Private Link Resource
*/
@JsonProperty(value = "properties")
private SharedPrivateLinkResourceProperties innerProperties;
Expand All @@ -40,7 +40,7 @@ public SystemData systemData() {
}

/**
* Get the innerProperties property: Describes the properties of a Shared Private Link Resource.
* Get the innerProperties property: Describes the properties of an existing Shared Private Link Resource.
*
* @return the innerProperties value.
*/
Expand Down Expand Up @@ -95,7 +95,7 @@ public SharedPrivateLinkResourceInner withPrivateLinkResourceId(String privateLi
}

/**
* Get the provisioningState property: Provisioning state of the shared private link resource.
* Get the provisioningState property: Provisioning state of the resource.
*
* @return the provisioningState value.
*/
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ public final class SharedPrivateLinkResourceProperties {
private String privateLinkResourceId;

/*
* Provisioning state of the shared private link resource
* Provisioning state of the resource.
*/
@JsonProperty(value = "provisioningState", access = JsonProperty.Access.WRITE_ONLY)
private ProvisioningState provisioningState;
Expand Down Expand Up @@ -89,7 +89,7 @@ public SharedPrivateLinkResourceProperties withPrivateLinkResourceId(String priv
}

/**
* Get the provisioningState property: Provisioning state of the shared private link resource.
* Get the provisioningState property: Provisioning state of the resource.
*
* @return the provisioningState value.
*/
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ public final class WebPubSubHubInner extends ProxyResource {
private SystemData systemData;

/*
* Properties of the hub setting.
* Properties of a hub.
*/
@JsonProperty(value = "properties", required = true)
private WebPubSubHubProperties properties;
Expand All @@ -39,7 +39,7 @@ public SystemData systemData() {
}

/**
* Get the properties property: Properties of the hub setting.
* Get the properties property: Properties of a hub.
*
* @return the properties value.
*/
Expand All @@ -48,7 +48,7 @@ public WebPubSubHubProperties properties() {
}

/**
* Set the properties property: Properties of the hub setting.
* Set the properties property: Properties of a hub.
*
* @param properties the properties value to set.
* @return the WebPubSubHubInner object itself.
Expand Down
Loading