[Azure RBAC] Remove deprecated flags#16
Merged
bgriddaluru merged 43 commits intomainfrom Oct 28, 2025
Merged
Conversation
* forcedelete * format * add code owner * mypy
* Add parameterization for the airgapped clouds * Fix azdev style * MCR path function * azdev, ruff, and mypy --------- Co-authored-by: Matthew McNeal (from Dev Box) <mmcneal@microsoft.com>
Co-authored-by: mmcneal <mmcneal@microsoft.com>
* update errors * format * style
* Update cluster diagnostics helm chart to 1.29.3 * Fix lint issues --------- Co-authored-by: bgriddaluru <bharath.griddaluru@microsoft.com>
vineeth-thumma
requested review from
anagg929,
atchutbarli,
bavneetsingh16 and
deeksha345
as code owners
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
There was a problem hiding this comment.
Pull Request Overview
This PR addresses RBAC deprecation and fixes an UnboundLocalError issue in the Connected Kubernetes extension. The changes remove deprecated --app-id and --app-secret flags, fix a variable initialization bug when only Azure RBAC features are enabled, and improve user guidance for kubelogin version requirements.
- Removed deprecated
--app-idand--app-secretflags from the connectedk8s extension - Fixed UnboundLocalError by initializing variables that may be used when only azure-rbac feature is enabled
- Enhanced kubelogin warning message to be more actionable with download link and troubleshooting guidance
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/connectedk8s/azext_connectedk8s/custom.py | Fixed variable initialization bug and improved kubelogin warning message |
| src/connectedk8s/azext_connectedk8s/_params.py | Removed deprecated RBAC command line parameters |
| src/connectedk8s/HISTORY.rst | Updated release notes with bug fixes and deprecation changes |
vineeth-thumma
changed the title
* forcedelete * format * add code owner * mypy
* update errors * format * style
bavneetsingh16
force-pushed
the
main
branch
from
34ff6f5 to
4d39530
Compare
added 2 commits
September 15, 2025 18:42
added 2 commits
September 16, 2025 11:50
bavneetsingh16
force-pushed
the
main
branch
from
abe399a to
2eb71cf
Compare
* forcedelete * format * add code owner * mypy
… '2025-08-01-preview' (#17)
bavneetsingh16
force-pushed
the
main
branch
from
2eb71cf to
329e119
Compare
vineeth-thumma
changed the title
…add E2E coverage and improve logging (#20) * add pester tests for connectedk8s cli extension * Pass the force delete param to the API call (#4) * forcedelete * format * add code owner * mypy * Parameterize for airgapped clouds (#5) * Add parameterization for the airgapped clouds * Fix azdev style * MCR path function * azdev, ruff, and mypy --------- Co-authored-by: Matthew McNeal (from Dev Box) <mmcneal@microsoft.com> * Oras client fix to work with different MCRs (#6) Co-authored-by: mmcneal <mmcneal@microsoft.com> * fix CI testcases for nodepool image issues (#8) * update errors for the config and connectivity issues (#11) * update errors * format * style * update python version to 3.13 (#12) * Update cluster diagnostics image to 1.29.3 (#7) * Update cluster diagnostics helm chart to 1.29.3 * Fix lint issues --------- Co-authored-by: bgriddaluru <bharath.griddaluru@microsoft.com> * RBAC deprecation & fix the issue * typo * fix comments * update tests * add pester tests for connectedk8s cli extension * Pass the force delete param to the API call (#4) * forcedelete * format * add code owner * mypy * fix CI testcases for nodepool image issues (#8) * update errors for the config and connectivity issues (#11) * update errors * format * style * update python version to 3.13 (#12) * rebase * fix tests * fix version * fix mypy, lint * fix test * fix test * fix test * fix test * fix test * rename test * deprecate flags * rebase * rebase * bump version for release --------- Co-authored-by: Bavneet Singh <bavneetsingh@microsoft.com> Co-authored-by: Atchut Kumar Barli <atchut@gmail.com> Co-authored-by: mcnealm13 <57726243+mcnealm13@users.noreply.github.com> Co-authored-by: Matthew McNeal (from Dev Box) <mmcneal@microsoft.com> Co-authored-by: Bavneet Singh <33008256+bavneetsingh16@users.noreply.github.com> Co-authored-by: bgriddaluru <117554445+bgriddaluru@users.noreply.github.com> Co-authored-by: bgriddaluru <bharath.griddaluru@microsoft.com> Co-authored-by: vithumma <vithumma@microsoft.com>
bavneetsingh16
force-pushed
the
main
branch
2 times, most recently
from
f2e906b to
3c08eac
Compare
added 2 commits
September 30, 2025 15:53
vineeth-thumma
changed the title
vineeth-thumma
changed the title
vineeth-thumma
changed the title
vineeth-thumma
removed
the
Do Not Merge
added 2 commits
October 28, 2025 09:17
…ctedk8s into vithumma/az_rbac
…rnetes/connectedk8s into vithumma/az_rbac
bgriddaluru
approved these changes
Oct 28, 2025
atchutbarli
approved these changes
Oct 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--app-idand--app-secretflags from theconnectedk8sextension.Since the change will remove deprecated parameters, this should go in as part of the upcoming breaking changes release:
https://github.com/Azure/azure-cli/milestone/162
https://eng.ms/docs/cloud-ai-platform/azure-core/azure-experiences-and-ecosystems/azure-portal-and-client-tools-ruhim/azure-cli-tools-azure-cli-powershell-and-terraform/azure-cli-tools/teams_docs/azcli_docs/breaking_changes
UT/E2E run - https://dev.azure.com/ClusterConfigurationAgent/Extension%20CLI/_build/results?buildId=5287894&view=results
Relevant WI: https://msazure.visualstudio.com/AzureArcPlatform/_workitems/edit/35025766
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.