forked from Azure/azure-cli-extensions
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding a flag for AKS to AMLARC migration and set up corresponding FE… #65
Merged
jonathan-innis
merged 7 commits into
AzureArcForKubernetes:k8s-extension/public
from
tianchijushi:huayang/fe-migration
Aug 12, 2021
Merged
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
9f4393c
Adding a flag for AKS to AMLARC migration and set up corresponding FE…
60783c7
Remove one extra line
c0cc8c9
Merge branch 'k8s-extension/public' into huayang/fe-migration
jonathan-innis 8432720
Merge branch 'k8s-extension/public' into huayang/fe-migration
jonathan-innis 438fa13
Adding Scoring FE IS_AKS_MIGRATION check logic for helm values
af43486
Merge branch 'k8s-extension/public' into huayang/fe-migration
jonathan-innis aec0ded
Merge branch 'k8s-extension/public' into huayang/fe-migration
jonathan-innis File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How will this work? Customer may pass any name for the extension and that is used as Helm release name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree. I think you are looking at an old pr version. In the latest version we skip setting up the release-name now and then in AMLARC we could use Helm Release.name instead