Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yuyu3/change amlk8s to amlarc #39

Closed
wants to merge 2 commits into from
Closed

Yuyu3/change amlk8s to amlarc #39

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
65e50ae
change amlk8s to amlarc
May 20, 2021
012ec2f
change setup_private.py
May 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
change amlk8s to amlarc
  • Loading branch information
Yue Yu committed May 20, 2021
commit 65e50ae5dde599a09738c17165f9409fa33e1ff5
5 changes: 5 additions & 0 deletions src/k8s-extension/HISTORY_private.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,11 @@
Release History
===============

0.4.0-beta.2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these meant to be private changes or changes for public-preview?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is meant to be for public preview, in that case should I just open a PR against the public branch or open PRs for both public and private branch?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also created a PR against the public branch. Thanks.
#42

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just public, we handle downstream merging so when you are making a change that should be public, please make it against k8s-extension/public

++++++++++++++++++

* Change resource tag from 'amlk8s' to 'Azure Arc-enabled ML' in microsoft.azureml.kubernetes

0.4.0-beta.1
++++++++++++++++++

Expand Down
6 changes: 3 additions & 3 deletions src/k8s-extension/azext_k8s_extension/partner_extensions/AzureMLKubernetes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@

logger = get_logger(__name__)

resource_tag = {'created_by': 'amlk8s-extension'}
resource_tag = {'created_by': 'Azure Arc-enabled ML'}


class AzureMLKubernetes(PartnerExtensionModel):
Expand Down Expand Up @@ -271,10 +271,10 @@ def _lock_resource(cmd, lock_scope, lock_level='CanNotDelete'):
lock_client: azure.mgmt.resource.locks.ManagementLockClient = get_mgmt_service_client(
cmd.cli_ctx, azure.mgmt.resource.locks.ManagementLockClient)
# put lock on relay resource
lock_object = ManagementLockObject(level=lock_level, notes='locked by amlk8s.')
lock_object = ManagementLockObject(level=lock_level, notes='locked by amlarc.')
try:
lock_client.management_locks.create_or_update_by_scope(
scope=lock_scope, lock_name='amlk8s-resource-lock', parameters=lock_object)
scope=lock_scope, lock_name='amlarc-resource-lock', parameters=lock_object)
except:
# try to lock the resource if user has the owner privilege
pass
Expand Down