Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename WorkloadIAM to EntraWorkloadIAM #273

Conversation

AntonioND
Copy link

The extension type name of microsoft.workloadiam has been changed to microsoft.entraworkloadiam. This PR updates k8s-extension to recognize the new name.


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az k8s-extension

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@AntonioND
Copy link
Author

I'm not sure what the errors in the pipeline mean, they don't seem related to this PR.

@Arif-lakhani
Copy link
Collaborator

What happens to the customer that try to use microsoft.workloadiam and the customers who have setup CI pipeline with microsoft.workloadiam? Do we show any deprecation message or a way for them to know about the name change?

@AntonioND
Copy link
Author

AntonioND commented Feb 6, 2024

What happens to the customer that try to use microsoft.workloadiam and the customers who have setup CI pipeline with microsoft.workloadiam? Do we show any deprecation message or a way for them to know about the name change?

Right now we are in private preview, preparing for public preview. We know the customers that are using the extension and we are going to notify them of the change. We don't expect anyone to be using this extension in production right now.

Copy link
Collaborator

@Arif-lakhani Arif-lakhani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AntonioND
Copy link
Author

Any updates about when this PR will be merged?

Copy link

@kulalking kulalking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@Arif-lakhani Arif-lakhani merged commit 02e9f06 into AzureArcForKubernetes:k8s-extension/public Mar 8, 2024
17 checks passed
@AntonioND AntonioND deleted the anninodi/name branch March 11, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants