Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove create cmd for flux v1 #268

Open
wants to merge 5 commits into
base: k8s-configuration
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 0 additions & 30 deletions src/k8s-configuration/README.rst
Original file line number Diff line number Diff line change
Expand Up @@ -61,22 +61,6 @@ az k8s-configuration flux list \
Source Control Configuration (Flux v1) Configuration: [more info](https://docs.microsoft.com/en-us/azure/kubernetessconfiguration/)\
*Examples:*

##### Create a Source Control Configuration (Flux v1)
```
az k8s-configuration create \
--resource-group groupName \
--cluster-name clusterName \
--cluster-type clusterType \
--name configurationName \
--operator-instance-name operatorInstanceName \
--operator-namespace operatorNamespace \
--repository-url githubRepoUrl \
--operator-params operatorParameters \
--enable-helm-operator \
--helm-operator-version chartVersion \
--helm-operator-params chartParameters
```

##### Get a Source Control Configuration (Flux v1)
```
az k8s-configuration show \
Expand All @@ -95,20 +79,6 @@ az k8s-configuration delete \
--name configurationName
```

##### Update a Source Control Configuration (Flux v1)
```
az k8s-configuration create \
--resource-group groupName \
--cluster-name clusterName \
--cluster-type clusterType \
--name configurationName \
--repository-url githubRepoUrl \
--operator-params operatorParameters \
--enable-helm-operator \
--helm-operator-version chartVersion \
--helm-operator-params chartParameters
```

##### List all Source Control Configuration (Flux v1) on a cluster
```
az k8s-configuration list \
Expand Down
17 changes: 0 additions & 17 deletions src/k8s-configuration/azext_k8s_configuration/_help.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,23 +13,6 @@
short-summary: Commands to manage resources from Microsoft.KubernetesConfiguration.
"""

helps[
"k8s-configuration create"
] = """
type: command
short-summary: Create a Flux v1 Kubernetes configuration (This command is for Flux v1, to use the newer Flux v2, run "az k8s-configuration flux create").
examples:
- name: Create a Flux v1 Kubernetes configuration
text: |-
az k8s-configuration create --resource-group MyResourceGroup --cluster-name MyClusterName \\
--cluster-type connectedClusters --name MyGitConfig --operator-instance-name OperatorInst01 \\
--operator-namespace OperatorNamespace01 --operator-type flux --operator-params "'--git-readonly'" \\
--repository-url git://github.com/fluxHowTo/flux-get-started --enable-helm-operator \\
--helm-operator-chart-version 1.4.0 --scope namespace --helm-operator-params '--set helm.versions=v3' \\
--ssh-private-key '' --ssh-private-key-file '' --https-user '' --https-key '' \\
--ssh-known-hosts '' --ssh-known-hosts-file ''
"""

helps[
"k8s-configuration list"
] = """
Expand Down
81 changes: 0 additions & 81 deletions src/k8s-configuration/azext_k8s_configuration/_params.py
Original file line number Diff line number Diff line change
Expand Up @@ -282,87 +282,6 @@ def load_arguments(self, _):
validator=validate_configuration_name,
)

with self.argument_context("k8s-configuration create") as c:
c.argument(
"repository_url",
options_list=["--repository-url", "-u"],
help="Url of the source control repository",
)
c.argument(
"scope",
arg_type=get_enum_type(["namespace", "cluster"]),
help="""Specify scope of the operator to be 'namespace' or 'cluster' """,
)
c.argument(
"enable_helm_operator",
arg_group="Helm Operator",
arg_type=get_three_state_flag(),
options_list=["--enable-helm-operator", "--enable-hop"],
help="Enable support for Helm chart deployments",
)
c.argument(
"helm_operator_params",
arg_group="Helm Operator",
options_list=["--helm-operator-params", "--hop-params"],
help="Chart values for the Helm Operator (if enabled)",
)
c.argument(
"helm_operator_chart_version",
arg_group="Helm Operator",
options_list=["--helm-operator-chart-version", "--hop-chart-version"],
help="Chart version of the Helm Operator (if enabled)",
)
c.argument(
"operator_params", arg_group="Operator", help="Parameters for the Operator"
)
c.argument(
"operator_instance_name",
arg_group="Operator",
help="Instance name of the Operator",
validator=validate_operator_instance_name,
)
c.argument(
"operator_namespace",
arg_group="Operator",
help="Namespace in which to install the Operator",
validator=validate_operator_namespace,
)
c.argument(
"operator_type",
arg_group="Operator",
help="""Type of the operator. Valid value is 'flux' """,
)
c.argument(
"ssh_private_key",
arg_group="Auth",
help="Specify Base64-encoded private ssh key for private repository sync",
)
c.argument(
"ssh_private_key_file",
arg_group="Auth",
help="Specify file path to private ssh key for private repository sync",
)
c.argument(
"https_user",
arg_group="Auth",
help="Specify HTTPS username for private repository sync",
)
c.argument(
"https_key",
arg_group="Auth",
help="Specify HTTPS token/password for private repository sync",
)
c.argument(
"ssh_known_hosts",
arg_group="Auth",
help="Specify Base64-encoded known_hosts contents containing public SSH keys required to access private Git instances",
)
c.argument(
"ssh_known_hosts_file",
arg_group="Auth",
help="Specify file path to known_hosts contents containing public SSH keys required to access private Git instances",
)

with self.argument_context("k8s-configuration flux kustomization") as c:
c.argument(
"kustomization_name",
Expand Down
5 changes: 0 additions & 5 deletions src/k8s-configuration/azext_k8s_configuration/commands.py
Original file line number Diff line number Diff line change
Expand Up @@ -87,11 +87,6 @@ def load_command_table(self, _):
k8s_configuration_sourcecontrol_client,
custom_command_type=source_control_configuration_custom_type,
) as g:
g.custom_command(
"create",
"create_config",
deprecate_info=self.deprecate(redirect="k8s-configuration flux create"),
)
g.custom_command(
"list",
"list_configs",
Expand Down
Loading
Loading