Skip to content

Require non-empty permission claims in OWIN APIs - #4009

Merged
Iarek Kovtunenko (iarekk) merged 3 commits into
masterfrom
iinglese/owin-auth-completion-minimal
Sep 14, 2026
Merged

Iarek Kovtunenko (iarekk) merged 3 commits into
masterfrom
iinglese/owin-auth-completion-minimal

Conversation

@iNinja

Copy link
Copy Markdown
Contributor

Summary

  • Require recognized OWIN scope or role claims to contain a non-empty value.
  • Preserve existing validation, request-token, challenge, and ACL-mode behavior.

Release notes

OWIN web APIs now require recognized scope or role claims to contain a non-empty
value unless application ACL mode is enabled.

Testing

  • 17 focused tests passed on .NET Framework 4.7.2.

@iNinja
Ignacio Inglese (iNinja) requested a review from a team as a code owner August 31, 2026 10:49

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Strengthens OWIN bearer-token validation by requiring recognized permission claims to have non-whitespace values.

Changes:

  • Rejects empty scope and role claims unless ACL authorization is enabled.
  • Preserves consumer callbacks and challenge forwarding.
  • Adds focused OWIN validation tests and release notes.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
AppBuilderExtension.cs Enforces non-empty permission claims.
OwinClaimsValidationTests.cs Covers claim values and callback behavior.
changelog.md Documents the validation change.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread changelog.md Outdated
Comment thread src/Microsoft.Identity.Web.OWIN/AppBuilderExtension.cs
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@iarekk
Iarek Kovtunenko (iarekk) force-pushed the iinglese/owin-auth-completion-minimal branch from db50d58 to a6208c4 Compare September 14, 2026 17:51
@iarekk
Iarek Kovtunenko (iarekk) merged commit da926fc into master Sep 14, 2026
9 checks passed
@iarekk
Iarek Kovtunenko (iarekk) deleted the iinglese/owin-auth-completion-minimal branch September 14, 2026 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants