fix CVEs #2929
Merged
fix CVEs #2929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kellyyangsong
approved these changes
Jul 15, 2024
kellyyangsong
pushed a commit
that referenced
this pull request
Jul 15, 2024
kellyyangsong
added a commit
that referenced
this pull request
Jul 15, 2024
1 task
czb182
reviewed
Jul 22, 2024
| <NetNineRuntimeVersion>9.0.0-preview.6.24327.7</NetNineRuntimeVersion> | ||
| <AspNetCoreNineRuntimeVersion>9.0.0-preview.6.24328.4</AspNetCoreNineRuntimeVersion> | ||
| <!--CVE-2024-30105--> | ||
| <SystemTextJsonVersion>8.0.4</SystemTextJsonVersion> |
There was a problem hiding this comment.
seems like this should have been the fixed version of the oldest currently support .net version which is .NET 6. Then in .net 8 and higher specific fields set the higher versions.
With this going to pull in .NET 8 oriented libraries in .NET 6 targeted applicaitons
There was a problem hiding this comment.
It's not going to pull .NET 8 libraries in .NET 6 applications as the libraries have different target framework
|
This would be a nuget depenency for system.text.json 8.0.4. Wouldn't that mean it would load that at runtime instead of framework version? Otherwise how would you be able to consume newer libraries for new features if for example I wanted to use some new system.text.json features in my .net 6 app.I don’t think this is big issue, just seems odd to cross .net libraries. I don’t think the .net 6 version of this this library was vulnerable so it didn’t need to reference new versionSent from my iPhoneOn Jul 22, 2024, at 5:02 PM, Jean-Marc Prieur ***@***.***> wrote:
@jmprieur commented on this pull request.
In Directory.Build.props:
@@ -88,21 +88,25 @@
<MicrosoftGraphBetaVersion>4.57.0-preview</MicrosoftGraphBetaVersion>
<MicrosoftExtensionsHttpVersion>3.1.3</MicrosoftExtensionsHttpVersion>
<MicrosoftIdentityAbstractions>6.0.0</MicrosoftIdentityAbstractions>
- <NetNineRuntimeVersion> 9.0.0-preview.4.24266.19</NetNineRuntimeVersion>
- <AspNetCoreNineRuntimeVersion> 9.0.0-preview.4.24267.6</AspNetCoreNineRuntimeVersion>
+ <NetNineRuntimeVersion>9.0.0-preview.6.24327.7</NetNineRuntimeVersion>
+ <AspNetCoreNineRuntimeVersion>9.0.0-preview.6.24328.4</AspNetCoreNineRuntimeVersion>
+ <!--CVE-2024-30105-->
+ <SystemTextJsonVersion>8.0.4</SystemTextJsonVersion>
It's not going to pull .NET 8 libraries in .NET 6 applications as the libraries have different target framework
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID: ***@***.***>
|
|
The .NET team recommends Microsoft.Extensions 8.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.