Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OWIN: Remove Microsoft.AspNet.WebApi.HelpPage dependency #2416

Merged

Conversation

Strepto
Copy link
Contributor

@Strepto Strepto commented Aug 31, 2023

OWIN: Remove Microsoft.AspNet.WebApi.HelpPage dependency

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

OWIN: Remove Microsoft.AspNet.WebApi.HelpPage dependency
The package auto copies a lot of unnecessary files to the target project, and the dependency cannot be removed while Microsoft.Identity.Web .OWIN is installed.

Description

By installing Microsoft.Identity.Web.Owin it auto adds all these files to my project through its (seemingly) unused dependency to Microsoft.AspNet.WebApi.HelpPage:
image

This PR removes the dependency.

Fixes #2417 (in this specific format)

The package auto copies a lot of unnecessary files to the
target project, and cannot be removed while Microsoft.Identity.Web
.OWIN is installed.
@jennyf19
Copy link
Collaborator

Awesome! Thanks for the contribution @Strepto

Copy link
Collaborator

@jennyf19 jennyf19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@jennyf19 jennyf19 merged commit a8bf5aa into AzureAD:master Aug 31, 2023
3 checks passed
@Strepto Strepto deleted the strepto/refac/remove-unused-dependency branch August 31, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OWIN: Dependency Microsoft.AspNet.WebApi.HelpPage adds files to the project through unused dependency
2 participants