Remove the reliance on getfqdn() #859
Merged
+18
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is not a breaking change, because the pre-existing implementation will error out anyway, but with a less meaningful exception.
gladjohn
approved these changes
Oct 22, 2025
Avery-Dunn
approved these changes
Oct 23, 2025
bgavrilMS
approved these changes
Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our reliance on
socket.getfqdn()was introduced since day 1 of adding managed identity feature. In the following 16 months, there were 2 isolated cases (example) where the machine(s) were not properly configured, and they were both resolved by fixing the machine's network setup.Nonetheless, this PR removes the reliance on
socket.getfqdn()so that we won't run into this in the future.