Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable broker support on Linux #766
base: dev
Are you sure you want to change the base?
Enable broker support on Linux #766
Changes from 2 commits
d2fc35f
edf77b4
3bf9111
caab447
aa5c74c
6f52d28
57d0005
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question: Does the Linux broker require yet another new redirect_uri being registered? If so, please also update the documentation here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you released or do you plan to release 0.18.0 for Linux? I saw right now it's still 0.17.1
https://pypi.org/project/pymsalruntime/#history
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have not yet released 0.18.0, but i'll be making that release soon, and this will be the first package with linux broker support
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: This PR shall be changed to a draft. We won't merge it in until pymsalruntime 0.18 being released.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we ensure the next release of
pymsalruntime
have whls built for Python 3.13 as well? The latest version ofpymsalruntime
doesn't seem to have that.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, you find this test file, please make sure it is able to invoke broker and you need to manually finish the signin process in the broker prompt.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
praise: Thanks for finding this test file!
suggestion: If you haven't already, please also do
python -m unittest tests.test_e2e
and make sure we won't run into any issue. Note that you will need to setup an.env
first, whose content is described at the beginning of this test_e2e.py file.