Skip to content

[SSH] SSH support including ATs bound to keys #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Sep 27, 2019
Merged

[SSH] SSH support including ATs bound to keys #102

merged 9 commits into from
Sep 27, 2019

Conversation

bgavrilMS
Copy link
Member

No description provided.

bgavrilMS and others added 6 commits September 26, 2019 20:19
@bgavrilMS
Fix test
ba9195b
@rayluo
Do not use casefold()
4b720be
@rayluo
Move _validate_ssh_cert_input_data() to outer layer
ea5fe1b 
This at least avoids the performance penalty in those implicit loops
inside acquire_token_silent().
@rayluo
Code style
66bce8d 
"Don't use spaces around the = sign when used to indicate a keyword argument"
- quoted from https://www.python.org/dev/peps/pep-0008/#other-recommendations
@rayluo
General tidy up
8f534df
@rayluo
Move AT key_id test into its own unit test
4cfd228
rayluo
rayluo reviewed Sep 27, 2019
View reviewed changes
Copy link
Collaborator

@rayluo rayluo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! Nice to have an e2e test case to ensure it works!

As discussed off-line, I leave only one comment below, and let's do the "pair programming" for the rest. :-)

rayluo
rayluo approved these changes Sep 27, 2019
View reviewed changes
Copy link
Collaborator

@rayluo rayluo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank Bogdan for an amazing pair-programming experience! Ship it!

@rayluo rayluo merged commit 4550793 into dev Sep 27, 2019
@rayluo rayluo deleted the bogavril/ssh3 branch September 27, 2019 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rayluo rayluo rayluo approved these changes

@abhidnya13 abhidnya13 Awaiting requested review from abhidnya13

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bgavrilMS @rayluo