Skip to content

Conversation

tnorling
Copy link
Collaborator

Changes to the broker model make the isBroker flag unnecessary, removing.

@tnorling tnorling marked this pull request as ready for review October 1, 2025 21:53
@tnorling tnorling requested a review from a team as a code owner October 1, 2025 21:53
@Copilot Copilot AI review requested due to automatic review settings October 1, 2025 21:53
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the isBroker parameter from the initialize method across the MSAL browser library as part of changes to the broker model that make this flag unnecessary.

  • Removes the isBroker parameter from the initialize method signature in controllers and interfaces
  • Simplifies the initialization logic by removing broker-specific conditional code
  • Updates tests to reflect the simplified initialization interface

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
lib/msal-browser/src/controllers/IController.ts Updates interface to remove isBroker parameter from initialize method
lib/msal-browser/src/controllers/StandardController.ts Removes isBroker parameter and conditional broker logic from initialize method
lib/msal-browser/src/controllers/NestedAppAuthController.ts Removes unused isBroker parameter from initialize method
lib/msal-browser/src/app/PublicClientApplication.ts Updates call to controller initialize to remove isBroker argument
lib/msal-browser/test/app/PublicClientApplication.spec.ts Removes test that verified isBroker parameter passing
lib/msal-browser/apiReview/msal-browser.api.md Updates API documentation to reflect removed parameter
change/@azure-msal-browser-08e8affc-ae18-41c2-821d-112c37fbdbdb.json Beachball change file for tracking this patch-level change

sameerag
sameerag previously approved these changes Oct 2, 2025
Copy link
Member

@sameerag sameerag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is because it is no longer a PCA instance?

tnorling and others added 2 commits October 13, 2025 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants