[msal-v5] Add support for "pageException" error to fallback to web #8065
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for handling "pageException" as a fatal native authentication error in MSAL.js, aligning the client-side behavior with server-side fallback logic. When a page exception occurs, MSAL will now treat it as a fatal error and fall back to web authentication.
Key Changes
- Added
pageExceptionas a new native authentication error code - Updated fatal error detection logic to include page exceptions
- Added comprehensive test coverage for the new error handling
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| lib/msal-browser/src/error/NativeAuthErrorCodes.ts | Exports new pageException error code constant |
| lib/msal-browser/src/error/NativeAuthError.ts | Updates isFatalNativeAuthError function to treat page exceptions as fatal |
| lib/msal-browser/test/error/NativeAuthError.spec.ts | Adds test case to verify page exception is handled as fatal error |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PageException is currently not being handled as a fatal error by MSAL JS, but the server falls back to web if it encounters the same. This PR addresses the gap.