Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix type resolution when using moduleResolution node16 #7284

Merged
merged 25 commits into from
Sep 19, 2024
Merged

Fix type resolution when using moduleResolution node16 #7284

merged 25 commits into from
Sep 19, 2024

Conversation

tnorling
Copy link
Collaborator

@tnorling tnorling commented Aug 29, 2024 •
edited
Loading

Type resolution is broken for node16 resolution type due to several issues, this PR:

  • Updates all relative imports to include .js file extension, as required by node16 resolution
  • Includes type declaration files from lib folder in package publish
  • Adds package.json file to lib folder to indicate contents are commonjs
  • Updates package exports field to point to the appropriate type declaration files for ESM or CJS
  • Adds browser and node subpaths to msal-common export to separate node-only and browser-only features

Fixes #6781 #6487 #6269

@tnorling tnorling linked an issue Aug 29, 2024 that may be closed by this pull request
msal-react: only publishing as ESM breaks jest tests #6487
Closed
@github-actions github-actions bot added msal-node Related to msal-node package msal-browser Related to msal-browser package msal-common Related to msal-common package labels Aug 29, 2024
@github-actions github-actions bot added msal-react Related to @azure/msal-react extensions Related to extensions for the base libraries labels Aug 29, 2024
@github-actions github-actions bot added the documentation Related to documentation. label Sep 11, 2024
@tnorling tnorling linked an issue Sep 11, 2024 that may be closed by this pull request
@azure/msal-browser transitively includes @types/node via @azure/msal-common and breaks typings #6269
Closed
@github-actions github-actions bot added the msal-angular Related to @azure/msal-angular package label Sep 18, 2024
@github-actions github-actions bot removed the msal-angular Related to @azure/msal-angular package label Sep 18, 2024
@tnorling tnorling merged commit 5a68dbb into dev Sep 19, 2024
6 of 8 checks passed
@tnorling tnorling deleted the fix-cjs-types branch September 19, 2024 18:52
@yukun-dong yukun-dong mentioned this pull request Sep 24, 2024
Open
@tnorling tnorling mentioned this pull request Oct 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@konstantin-msft konstantin-msft konstantin-msft approved these changes

@sameerag sameerag sameerag approved these changes

@jo-arroyo jo-arroyo Awaiting requested review from jo-arroyo jo-arroyo is a code owner

@peterzenz peterzenz Awaiting requested review from peterzenz peterzenz is a code owner

@hectormmg hectormmg Awaiting requested review from hectormmg hectormmg is a code owner

@bgavrilMS bgavrilMS Awaiting requested review from bgavrilMS bgavrilMS is a code owner

@Robbie-Microsoft Robbie-Microsoft Awaiting requested review from Robbie-Microsoft Robbie-Microsoft is a code owner

@trwalke trwalke Awaiting requested review from trwalke

@pmaytak pmaytak Awaiting requested review from pmaytak

@gladjohn gladjohn Awaiting requested review from gladjohn

@neha-bhargava neha-bhargava Awaiting requested review from neha-bhargava

@rayluo rayluo Awaiting requested review from rayluo

@Avery-Dunn Avery-Dunn Awaiting requested review from Avery-Dunn

@lalimasharda lalimasharda Awaiting requested review from lalimasharda lalimasharda is a code owner

Assignees
No one assigned
Labels
documentation Related to documentation. extensions Related to extensions for the base libraries msal-browser Related to msal-browser package msal-common Related to msal-common package msal-node Related to msal-node package msal-react Related to @azure/msal-react
Projects
None yet
Milestone
No milestone
4 participants
@tnorling @sameerag @konstantin-msft @hectormmg