Consistently use SLF4J's recommended styles #992
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgavrilMS
approved these changes
Sep 16, 2025
neha-bhargava
approved these changes
Sep 16, 2025
neha-bhargava
approved these changes
Sep 16, 2025
gladjohn
approved these changes
Sep 17, 2025
| return StringHelper.convertToMultiValueMap(this.requestParameters); | ||
| } | ||
|
|
||
| public Logger log() { |
There was a problem hiding this comment.
No, and weirdly there are few other places where we have an unused getter for the Logger.
However, this PR was just meant to handle one very low-risk issue in bulk, and I will be handling unused methods like this in smaller, more focused PRs where it's easier to see if there are unintended side effects.
There was a problem hiding this comment.
Ok thanks. Suggest having a new task for removing unused methods if there isn't one already.
msal4j-sdk/src/main/java/com/microsoft/aad/msal4j/CloudShellManagedIdentitySource.java
Outdated
Show resolved
Hide resolved
msal4j-sdk/src/main/java/com/microsoft/aad/msal4j/MexParser.java
Outdated
Show resolved
Hide resolved
msal4j-sdk/src/main/java/com/microsoft/aad/msal4j/MexParser.java
Outdated
Show resolved
Hide resolved
…nagedIdentitySource.java Co-authored-by: Gladwin Johnson <90415114+gladjohn@users.noreply.github.com>
Co-authored-by: Gladwin Johnson <90415114+gladjohn@users.noreply.github.com>
Co-authored-by: Gladwin Johnson <90415114+gladjohn@users.noreply.github.com>
gladjohn
approved these changes
Sep 17, 2025
|
looks good @Avery-Dunn |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the logging throughout the codebase to be more consistent and efficient by following SLF4J's recommended styles.
Many classes received changes, but same two changes were made to each one:
private static final Logger LOG = ...Only logging statements were affected and there were no changes to the actual messages that get logged, so the actual behavior of the library is unchanged.