Add a distinct MsalJsonParsingException for JSON parsing failures#933
Merged
Avery-Dunn merged 5 commits intodevfrom Apr 7, 2025
Merged
Add a distinct MsalJsonParsingException for JSON parsing failures#933Avery-Dunn merged 5 commits intodevfrom
Avery-Dunn merged 5 commits intodevfrom
Conversation
billwert
approved these changes
Apr 4, 2025
billwert
approved these changes
Apr 4, 2025
msal4j-sdk/src/main/java/com/microsoft/aad/msal4j/MsalErrorMessage.java
Outdated
Show resolved
Hide resolved
msal4j-sdk/src/test/java/com/microsoft/aad/msal4j/ManagedIdentityTests.java
Show resolved
Hide resolved
neha-bhargava
previously approved these changes
Apr 4, 2025
Contributor
neha-bhargava
left a comment
neha-bhargava
left a comment
There was a problem hiding this comment.
Approved with suggestions
…tion-library-for-java into avdunn/mi-exceptions
neha-bhargava
approved these changes
Apr 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As explained in #907, Azure Identity used to have distinct exceptions for JSON parsing errors in MI scenarios, but MSAL did not add any when we implemented managed identity support.
This PR adds a distinct MsalJsonParsingException for JSON parsing errors in all flows, with a special message and code when thrown in MI flows. The message/code are similar to those added in MSAL.NET: AzureAD/microsoft-authentication-library-for-dotnet#5038