Skip to content

Add initial code for MSI #661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Sep 11, 2023
Merged

Add initial code for MSI #661

merged 10 commits into from
Sep 11, 2023

Conversation

@neha-bhargava
Copy link
Contributor

@neha-bhargava neha-bhargava commented Jun 20, 2023

Included in this PR:

  • Initial code for managed identity
  • Support for App service
  • Support for IMDS

Testing

  • Unit test
  • Sample app for Azure functions to test manually

@Avery-Dunn Avery-Dunn mentioned this pull request Aug 10, 2023
Closed
This was linked to issues Aug 14, 2023
[Feature Request] Add App service managed identity with initial managed identity work #616
Closed
[Feature Request] Add IMDS managed identity source to MSI integration #617
Closed
@neha-bhargava neha-bhargava marked this pull request as ready for review August 28, 2023 16:15
@Avery-Dunn Avery-Dunn self-requested a review August 28, 2023 18:30
bgavrilMS
bgavrilMS reviewed Aug 29, 2023
View reviewed changes
bgavrilMS
bgavrilMS reviewed Aug 29, 2023
View reviewed changes
bgavrilMS
bgavrilMS reviewed Aug 31, 2023
View reviewed changes
bgavrilMS
bgavrilMS reviewed Aug 31, 2023
View reviewed changes
bgavrilMS
bgavrilMS requested changes Aug 31, 2023
View reviewed changes
Copy link
Member

@bgavrilMS bgavrilMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs changes particularly on visibility modifiers / public API comments etc. Logic looks good.

@neha-bhargava neha-bhargava changed the base branch from dev to nebharg/MSI September 6, 2023 20:51
@neha-bhargava neha-bhargava merged commit aa7857a into nebharg/MSI Sep 11, 2023
@Avery-Dunn Avery-Dunn mentioned this pull request Mar 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bgavrilMS bgavrilMS bgavrilMS approved these changes

@Avery-Dunn Avery-Dunn Avery-Dunn approved these changes

+1 more reviewer

@localden localden localden left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

5 participants

@neha-bhargava @bgavrilMS @localden @Avery-Dunn