Retrieve configuration from key vault instead of API #593
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
4gust
approved these changes
Jan 21, 2026
bgavrilMS
approved these changes
Jan 21, 2026
RyAuld
approved these changes
Jan 21, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes similar changes to what is being done in other MSALs:
AzureAD/microsoft-authentication-library-for-java#1002
AzureAD/microsoft-authentication-library-for-dotnet#5631
Historically, integration tests in MSAL and MISE retrieved user/app/tenant/etc. info from our API at "https://msidlab.com/api/"
That API is being deprecated in favor of a key vault-based system: instead of dynamic config based on query parameters, we have a simpler set of config stored as key vault secrets.
This PR refactors the integration tests to retrieve the config they need from those key vaults instead of the API:
config_helpers_test.go: A new file to contain all of the helpers functions, constants, and structs used by the integration testsintegration_test.go: Removed helpers that retrieved config from the API, moved remaining helpers toconfig_helpers_test.go, adjusted tests to use the new helpersIn addition, some tests which were previously broken/skipped (
TestConfidentialClientWithSecretandTestOnBehalfOf) are now working again under the new system, which should resolve the unrelated issue #513