Update SNI MTLS PoP Token Design documentation - #6171
Open
Bogdan Gavril (bgavrilMS) wants to merge 2 commits into
Open
Update SNI MTLS PoP Token Design documentation#6171Bogdan Gavril (bgavrilMS) wants to merge 2 commits into
Bogdan Gavril (bgavrilMS) wants to merge 2 commits into
Conversation
Removed DSTS cloud endpoint details and updated authority type references from DSTS to STS.
Bogdan Gavril (bgavrilMS)
enabled auto-merge (squash)
August 28, 2026 11:58
Bogdan Gavril (bgavrilMS)
disabled auto-merge
August 28, 2026 11:58
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the SNI mTLS PoP token design document by removing DSTS cloud endpoint details and adjusting the documentation’s authority-type wording.
Changes:
- Removed the dedicated “DSTS Cloud” endpoint section.
- Updated authority-type references in the test validation section (DSTS → STS).
Suppressed comments (1)
docs/sni_mtls_pop_token_design.md:191
- Markdown emphasis marker
*is unbalanced (*STS), which can break formatting in rendered docs. Use plain text or close the emphasis marker.
- Region is not required if the authority is *STS.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
Suppressed comments (1)
docs/sni_mtls_pop_token_design.md:191
- Markdown formatting typo: the bullet starts an emphasis span with
*STSbut never closes it, which will render incorrectly and can italicize the remainder of the section.
- Region is not required if the authority is *STS.
| - Test with a valid tenanted authority URL (e.g., `https://login.microsoftonline.com/tenant_id`). | ||
| - Ensure an exception (`MsalError.MissingTenantedAuthority`) is thrown for `/common` or `/organizations` authority usage. | ||
| - Flow is applicable only to AAD and DSTS authorities. Verify that unsupported authority types (e.g., B2C) throw `MsalError.InvalidAuthorityType`. | ||
| - Flow is applicable only to AAD and STS authorities. Verify that unsupported authority types (e.g., B2C) throw `MsalError.InvalidAuthorityType`. |
Nilesh Choudhary (4gust)
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed STS cloud endpoint details and updated authority type references from STS to STS.
Fixes #
Changes proposed in this request
Testing
Performance impact
Documentation