Reduce hardcoded integration test config #5644
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RyAuld
reviewed
Jan 12, 2026
...s/Microsoft.Identity.Test.Integration.netcore/HeadlessTests/ClientCredentialsTests.NetFwk.cs
Show resolved
Hide resolved
RyAuld
approved these changes
Jan 12, 2026
gladjohn
reviewed
Jan 12, 2026
…/AzureAD/microsoft-authentication-library-for-dotnet into avdunn/lab-migration-reduce-apps
bgavrilMS
reviewed
Jan 14, 2026
...s/Microsoft.Identity.Test.Integration.netcore/HeadlessTests/ClientCredentialsTests.NetFwk.cs
Outdated
Show resolved
Hide resolved
bgavrilMS
approved these changes
Jan 14, 2026
RyAuld
approved these changes
Jan 15, 2026
gladjohn
approved these changes
Jan 15, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continues the lab migration work done in #5631 and other PRs.
This PR removes
ConfidentialAppSettingsand some other hardcoded configuration, and replaces it with calls to the new helpers inMicrosoft.Identity.Test.LabInfrastructure.Previous PRs performed a major refactor of the
Microsoft.Identity.Test.LabInfrastructurenamespace, to retrieve configuration required by integration tests from a key vault instead of an API. Those PRs also adjusted all of the tests that were usingMicrosoft.Identity.Test.LabInfrastructure, and generally reduced the number of lab resources that the tests needed.However, many of the confidential client tests were using a helper class called
ConfidentialAppSettings, which used a mix of hardcoded strings and calls toMicrosoft.Identity.Test.LabInfrastructureto provide configuration, and this would be hard to maintain going forward: https://github.com/AzureAD/microsoft-authentication-library-for-dotnet/blob/main/tests/Microsoft.Identity.Test.Integration.netcore/Infrastructure/ConfidentialAppSettings.csMost of the file changes were in test classes and are just now making calls to different helpers, the exceptions are:
ConfidentialAppSettings: Completely removed, previously provided hardcoded config based on cloud typeClientCredentialsTests.NetFwk: Expanded the internal helper method for setting the correct config based on the cloud typeAppConfig: Added some extra config fields required by tests that don't useUserConfig, such as tenant IDKeyVaultSecrets: Defined a few more names of key vault secrets which were previously missing or defined somewhere elseLabUserHelper: Added a new helper for retrieving a secret string from the key vault, for tests that deal with app secrets instead of user secrets