Bearer Requests should Fallback to IMDS in Preview #5562
Merged
+53
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gladjohn
changed the title
MZOLN
approved these changes
Oct 30, 2025
Avery-Dunn
approved these changes
Oct 30, 2025
Comment on lines
+1468
to
+1470
| [DataTestMethod] | ||
| [DataRow(UserAssignedIdentityId.None, null)] | ||
| [DataRow(UserAssignedIdentityId.ClientId, TestConstants.ClientId)] |
Contributor
There was a problem hiding this comment.
To be consistent with all other test, can you also add cases for ResourceId and ObjectId?
| using (new EnvVariableContext()) | ||
| using (var httpManager = new MockHttpManager()) | ||
| { | ||
| ManagedIdentityClient.ResetSourceForTest(); |
Contributor
There was a problem hiding this comment.
Don't we have something that runs before each test? Shouldn't this be put there?
Contributor
Robbie-Microsoft
left a comment
Robbie-Microsoft
left a comment
There was a problem hiding this comment.
Is this functionality temporary? If so, can you add comments in the code stating that this will be reversed when this hits GA?
| if ((source == ManagedIdentitySource.DefaultToImds) && isMtlsPopRequested) | ||
| // If the source is determined to be ImdsV1 and mTLS PoP was requested, | ||
| // throw an exception since ImdsV1 does not support mTLS PoP | ||
| if (source == ManagedIdentitySource.DefaultToImds && isMtlsPopRequested) |
Contributor
There was a problem hiding this comment.
Should this be elif? You want both if statements to run?
This was referenced Nov 10, 2025
Closed
Closed
This was referenced Nov 17, 2025
Closed
This was referenced Nov 24, 2025
Closed
This was referenced Dec 2, 2025
Closed
This was referenced Dec 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes - fallback to IMDS in Preview
We already fallback to IMDS in PROD. But when the MSI v2 endpoints exist, we do not fallback.
Changes proposed in this request
Testing
unit, integration and e2e
Performance impact
none
Documentation