Deprecate Kerberos API and remove tests #5476
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we also remove the |
gladjohn
approved these changes
Sep 12, 2025
Avery-Dunn
reviewed
Sep 12, 2025
src/client/Microsoft.Identity.Client/AppConfig/PublicClientApplicationBuilder.cs
Show resolved
Hide resolved
bgavrilMS
reviewed
Sep 15, 2025
src/client/Microsoft.Identity.Client/AppConfig/PublicClientApplicationBuilder.cs
Show resolved
Hide resolved
bgavrilMS
reviewed
Sep 15, 2025
src/client/Microsoft.Identity.Client/AppConfig/PublicClientApplicationBuilder.cs
Show resolved
Hide resolved
trwalke
approved these changes
Sep 16, 2025
bgavrilMS
reviewed
Sep 17, 2025
| /// </summary> | ||
| private void AddClaims() | ||
| { | ||
| #pragma warning disable CS0612 // Type or member is obsolete |
There was a problem hiding this comment.
Can we delete internal logic instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Deprecate Kerberos as it is no longer used as indicated by telemetry
Changes proposed in this request
Deprecate and remove tests
Testing
Performance impact
Documentation