Audit all info and verbose logs and use lambdas to generate strings#3919
Merged
Conversation
58f74de to
2bc9500
Compare
auto-merge was automatically disabled
January 26, 2023 15:30
Pull request was converted to draft
gladjohn
approved these changes
Feb 2, 2023
pmaytak
approved these changes
Feb 4, 2023
Contributor
pmaytak
left a comment
There was a problem hiding this comment.
Cool stuff. Based on perf tests, seems like it does help to not compute when logging is disabled. Would be nice though if there was a syntactic sugar to not add () => part - parameter is Func, you pass in a string, but compiler figures out to change it to a Func.
Co-authored-by: Peter M <34331512+pmaytak@users.noreply.github.com> Co-authored-by: Gladwin Johnson <90415114+gladjohn@users.noreply.github.com>
16366a5 to
0ef2cb5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3901
Changes proposed in this request
Testing
unit
Performance impact
** AcquireTokenForClient perf tests **
These were modified to run with
WithLogging(Console.WriteLine(msg), LogLevel.Info)Documentation
n/a