-
Notifications
You must be signed in to change notification settings - Fork 137
Add WebAuthn version support in configuration, Fixes AB#3385532 #2393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
p3dr0rv
wants to merge
12
commits into
dev
Choose a base branch
from
pedroro/passkey-test
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
5193bea
Add WebAuthn support and passkey header handling in configuration
p3dr0rv 6a2a75f
Update changelog to include WebAuthN version support and clarify head…
p3dr0rv 1c12a2a
Refactor WebAuthn version method name for consistency and update refe…
p3dr0rv 7f46b1c
Update msal/src/main/java/com/microsoft/identity/client/internal/Comm…
p3dr0rv 7c9e22d
Update testapps/testapp/src/main/java/com/microsoft/identity/client/t…
p3dr0rv 9919999
Update msal/src/main/java/com/microsoft/identity/client/internal/Comm…
p3dr0rv b36070d
Change log level from info to verbose for passkey header addition in …
p3dr0rv 3e17ed4
Enhance WebAuthn support: update passkey header logic and add tests f…
p3dr0rv e3a40d9
Add null check for WebAuthn version in passkey header logic
p3dr0rv bfefa21
Merge branch 'dev' into pedroro/passkey-test
p3dr0rv fcf6d71
Update passkey header logic for WebAuthn version 1.0 and add new conf…
p3dr0rv 1009327
eof
p3dr0rv File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Submodule common
updated
25 files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 changes: 15 additions & 0 deletions
15
testapps/testapp/src/main/res/raw/msal_config_webview_msa_passkey_reg.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| { | ||
| "client_id" : "9668f2bd-6103-4292-9024-84fa2d1b6fb2", | ||
| "authorization_user_agent" : "WEBVIEW", | ||
| "redirect_uri" : "msauth://com.msft.identity.client.sample.local/1wIqXSqBj7w%2Bh11ZifsnqwgyKrY%3D", | ||
| "webauthn_capable" : true, | ||
| "webauthn_version" : 1.1, | ||
| "authorities" : [ | ||
| { | ||
| "type": "AAD", | ||
| "audience": { | ||
| "type": "AzureADandPersonalMicrosoftAccount" | ||
| } | ||
| } | ||
| ] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.