Add native auth to MSAL test app #2001

SammyO · 2024-01-10T14:37:11Z

For MSAL team:

In order to let the native auth team execute (manual) release tests, an application is needed that supports the various use flows that are part of the release tests.

Changes:

The existing MSAL test app is extended with a Native Auth section, which is accessed from the side menu.
Updated CODEOWNERS to reflect native auth ownership of the newly added classes.

For native auth team:

Changes compared to previous versions of this application:

Sign up attributes are no longer hardcoded to country and city, but taken dynamically from the UI (through new key and value text fields).
AttributesRequired` state will navigate to the new, generic AttributesFragment. Logs need to be checked for details about which attributes are required, and thus which keys need to be supplied.
CodeFragment displays API's channel, sentTo and codeLength fields, which can now be used for validation for correct behaviour.

Note:
This application is not in a state where it can be used as a CI-generated artefact by the native auth team. Developers using this application will need to change the config JSON file and update it to one of several tenant configurations, recompile and run it. Support for native auth in the Labs environment is needed to make this application usable as a CI-generated artefact. Once Labs support is added, the native auth screens will need config selection UI, similar to the Fragment dedicated to testing acquireToken().

…ength, sentTo and channel in code UI.

…tautomation' into sammy/add-native-auth-to-msaltestautomation

fadidurah · 2024-01-11T17:44:48Z

...app/src/main/java/com/microsoft/identity/client/testapp/nativeauth/SignUpPasswordFragment.kt

@@ -0,0 +1,132 @@
+package com.microsoft.identity.client.testapp.nativeauth


Let's add License to all these new kotlin files

Done, and for all other .kt files

fadidurah

Need licenses in all new .kt files

fadidurah · 2024-01-12T02:57:29Z

testapps/testapp/build.gradle

Might be able to test the proguard rules in the dist variant of the test app now, since we incorporate native auth into it.

@Yuki-YuXin this is because test app is pulling an outdated MSAL version (4.x), one that doesn't have native auth included yet. I'll update this in the PR.

testapps/testapp/build.gradle

…tautomation' into sammy/add-native-auth-to-msaltestautomation # Conflicts: # testapps/testapp/build.gradle

testapps/testapp/src/main/res/layout/fragment_email_attribute.xml

shahzaibj · 2024-01-16T20:44:19Z

testapps/testapp/src/main/res/menu/bottom_navigation_menu.xml

+        android:icon="@drawable/ic_baseline_lock_reset_24"
+        android:title=" SSPR" />
+
+</menu>


nit: new line ending; here and everywhere

shahzaibj · 2024-01-17T00:23:05Z

testapps/testapp/build.gradle

            proguardFiles getDefaultProguardFile('proguard-android.txt'), 'proguard-rules.pro'
        }
    }
+    buildFeatures {


What does this do? and why is it needed?

What does this do

https://developer.android.com/topic/libraries/view-binding

why is it needed?

It's a much improved process of managing view (interactions, etc.) that has been rolled out by Android for quite some time. New and improved way of doing things.

shahzaibj · 2024-01-17T00:23:31Z

testapps/testapp/src/main/java/com/microsoft/identity/client/testapp/NativeAuthFragment.kt

+import com.microsoft.identity.client.testapp.nativeauth.EmailSignInSignUpFragment
+import com.microsoft.identity.client.testapp.nativeauth.PasswordResetFragment
+
+class NativeAuthFragment : Fragment() {


javadoc on all classes

I still don't see javadoc on this particular class though

shahzaibj · 2024-01-17T00:23:45Z

testapps/testapp/src/main/java/com/microsoft/identity/client/testapp/NativeAuthFragment.kt

+            commit()
+        }
+    }
+}


new line ending; here and everywhere

shahzaibj · 2024-01-17T00:23:59Z

testapps/testapp/src/main/java/com/microsoft/identity/client/testapp/nativeauth/Constants.kt

+//   THE SOFTWARE.
+package com.microsoft.identity.client.testapp.nativeauth
+
+interface Constants {


javadoc everywhere

shahzaibj · 2024-01-23T01:30:20Z

testapps/testapp/src/main/java/com/microsoft/identity/client/testapp/nativeauth/AuthClient.kt

+import com.microsoft.identity.nativeauth.INativeAuthPublicClientApplication
+
+/**
+ * Utility for managing MSAL SDK instance INativeAuthPublicClientApplication


Suggested change

* Utility for managing MSAL SDK instance INativeAuthPublicClientApplication

* Utility for managing MSAL SDK instance INativeAuthPublicClientApplication.

Also probably run code formatter

shahzaibj · 2024-01-23T01:31:53Z

testapps/testapp/src/main/java/com/microsoft/identity/client/testapp/Constants.java

+    public static final String STATE = "state";
+    public static final String CODE_LENGTH = "code_length";
+    public static final String SENT_TO = "sent_to";
+    public static final String CHANNEL = "channel";


Please add some short comments/javadoc describing these and mentioning that these are related to Native Auth (given that these are placed in shared class)

Basis for native auth extension of MSAL test app

16c8edd

github-actions bot added the testapps label Jan 10, 2024

SammyO added 3 commits January 11, 2024 16:17

Replace hardcoded attributes with dynamic, input-based. Include codeL…

867257d

…ength, sentTo and channel in code UI.

Remove unnecessary dependency

ddb1f2c

Merge branch 'dev' into sammy/add-native-auth-to-msaltestautomation

fc9b579

SammyO marked this pull request as ready for review January 11, 2024 16:24

SammyO requested a review from a team as a code owner January 11, 2024 16:24

Update code owners

179806d

SammyO added the No-Changelog This change does not update the changelog. label Jan 11, 2024

Merge remote-tracking branch 'origin/sammy/add-native-auth-to-msaltes…

e82f257

…tautomation' into sammy/add-native-auth-to-msaltestautomation

rmccahill approved these changes Jan 11, 2024

View reviewed changes

fadidurah reviewed Jan 11, 2024

View reviewed changes

fadidurah requested changes Jan 12, 2024

View reviewed changes

fadidurah reviewed Jan 12, 2024

View reviewed changes

Yuki-YuXin reviewed Jan 12, 2024

View reviewed changes

testapps/testapp/build.gradle Show resolved Hide resolved

SammyO added 2 commits January 12, 2024 16:20

Add licenses

805cd74

Merge branch 'dev' into sammy/add-native-auth-to-msaltestautomation

609e85b

SammyO requested a review from fadidurah January 12, 2024 16:22

fadidurah approved these changes Jan 12, 2024

View reviewed changes

SammyO added 3 commits January 15, 2024 11:30

Update MSAL dependency

dd05327

Merge remote-tracking branch 'origin/sammy/add-native-auth-to-msaltes…

288bf19

…tautomation' into sammy/add-native-auth-to-msaltestautomation # Conflicts: # testapps/testapp/build.gradle

Merge branch 'dev' into sammy/add-native-auth-to-msaltestautomation

42c8452

Yuki-YuXin reviewed Jan 15, 2024

View reviewed changes

testapps/testapp/src/main/res/layout/fragment_email_attribute.xml Show resolved Hide resolved

Yuki-YuXin approved these changes Jan 16, 2024

View reviewed changes

shahzaibj reviewed Jan 16, 2024

View reviewed changes

shahzaibj reviewed Jan 17, 2024

View reviewed changes

Address PR feedback

f6cf2ee

SammyO added 2 commits January 18, 2024 12:49

Merge branch 'dev' into sammy/add-native-auth-to-msaltestautomation

6e088ce

Merge branch 'dev' into sammy/add-native-auth-to-msaltestautomation

39b5130

shahzaibj reviewed Jan 23, 2024

View reviewed changes

shahzaibj approved these changes Jan 23, 2024

View reviewed changes

SammyO added 2 commits January 24, 2024 09:42

Merge branch 'dev' into sammy/add-native-auth-to-msaltestautomation

bcb755d

Update with latest changes

dbb5f0d

SammyO merged commit 1f146d0 into dev Jan 24, 2024

Yuki-YuXin mentioned this pull request Jan 23, 2025

Remove native auth from MSAL test app #2248

Open

		@@ -0,0 +1,132 @@
		package com.microsoft.identity.client.testapp.nativeauth

	* Utility for managing MSAL SDK instance INativeAuthPublicClientApplication
	* Utility for managing MSAL SDK instance INativeAuthPublicClientApplication.

Add native auth to MSAL test app #2001

Add native auth to MSAL test app #2001

Uh oh!

Conversation

SammyO commented Jan 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

For MSAL team:

For native auth team:

Uh oh!

fadidurah Jan 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fadidurah left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Yuki-YuXin Jan 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

SammyO Jan 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

SammyO commented Jan 10, 2024 •

edited

Loading

fadidurah Jan 11, 2024 •

edited

Loading

Yuki-YuXin Jan 12, 2024 •

edited

Loading

SammyO Jan 18, 2024 •

edited

Loading