Skip to content

Conversation

@fadidurah
Copy link
Contributor

@fadidurah fadidurah commented Jan 5, 2026

This PR expands our automation code to enable pulling the upn json string from the MobileBuildVault Key Vault

AB#3478938

Copilot AI review requested due to automatic review settings January 5, 2026 19:25
@fadidurah fadidurah requested a review from a team as a code owner January 5, 2026 19:25
@fadidurah fadidurah added the No-Changelog This Pull-Request has no associated changelog entry. label Jan 5, 2026
@github-actions
Copy link

github-actions bot commented Jan 5, 2026

❌ Work item link check failed. Description does not contain AB#{ID}.

Click here to Learn more.

@github-actions
Copy link

github-actions bot commented Jan 5, 2026

✅ Work item link check complete. Description contains link AB#3478938 to an Azure Boards work item.

@github-actions github-actions bot changed the title Add support for pulling the UPN json string Add support for pulling the UPN json string, Fixes AB#3478938 Jan 5, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR expands automation code capabilities by adding support for retrieving account UPN JSON data from the MobileBuildVault Key Vault. The changes introduce a new Key Vault endpoint configuration and add a method to fetch and cache a JSON structure containing user identifiers for test automation.

Key Changes

  • Introduced support for multiple Key Vault URLs (MSIDLABS and MobileBuildVault) in KeyVaultSecretsApi
  • Renamed getKeyVaultSecret() to getPasswordSecretFromLabsKeyVault() for better semantic clarity
  • Added new getAccountUpnJsonFromMobileBuildKeyVault() method with static caching to retrieve and cache account UPN mappings from MobileBuildVault

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.

File Description
labapi/src/main/java/com/microsoft/identity/internal/test/labapi/api/KeyVaultSecretsApi.java Introduced public constants for MSIDLABS and MobileBuildVault URLs to support multiple Key Vault sources
LabApiUtilities/src/main/com/microsoft/identity/labapi/utilities/client/ILabClient.java Renamed interface method and added new method signature for fetching account UPN JSON from MobileBuildVault
LabApiUtilities/src/main/com/microsoft/identity/labapi/utilities/client/LabClient.java Implemented renamed method, added new cached UPN JSON fetching method with static caching, and defined public constants for JSON structure keys
LabApiUtilities/src/test/com/microsoft/identity/labapi/utilities/client/LabClientTest.java Added integration tests validating password secret retrieval and account UPN JSON structure from Key Vaults

Copy link
Contributor

@mohitc1 mohitc1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

No-Changelog This Pull-Request has no associated changelog entry.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants