-
Notifications
You must be signed in to change notification settings - Fork 46
Add support for pulling the UPN json string, Fixes AB#3478938 #2854
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
|
❌ Work item link check failed. Description does not contain AB#{ID}. Click here to Learn more. |
|
✅ Work item link check complete. Description contains link AB#3478938 to an Azure Boards work item. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR expands automation code capabilities by adding support for retrieving account UPN JSON data from the MobileBuildVault Key Vault. The changes introduce a new Key Vault endpoint configuration and add a method to fetch and cache a JSON structure containing user identifiers for test automation.
Key Changes
- Introduced support for multiple Key Vault URLs (MSIDLABS and MobileBuildVault) in
KeyVaultSecretsApi - Renamed
getKeyVaultSecret()togetPasswordSecretFromLabsKeyVault()for better semantic clarity - Added new
getAccountUpnJsonFromMobileBuildKeyVault()method with static caching to retrieve and cache account UPN mappings from MobileBuildVault
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
labapi/src/main/java/com/microsoft/identity/internal/test/labapi/api/KeyVaultSecretsApi.java |
Introduced public constants for MSIDLABS and MobileBuildVault URLs to support multiple Key Vault sources |
LabApiUtilities/src/main/com/microsoft/identity/labapi/utilities/client/ILabClient.java |
Renamed interface method and added new method signature for fetching account UPN JSON from MobileBuildVault |
LabApiUtilities/src/main/com/microsoft/identity/labapi/utilities/client/LabClient.java |
Implemented renamed method, added new cached UPN JSON fetching method with static caching, and defined public constants for JSON structure keys |
LabApiUtilities/src/test/com/microsoft/identity/labapi/utilities/client/LabClientTest.java |
Added integration tests validating password secret retrieval and account UPN JSON structure from Key Vaults |
LabApiUtilities/src/main/com/microsoft/identity/labapi/utilities/client/LabClient.java
Outdated
Show resolved
Hide resolved
LabApiUtilities/src/main/com/microsoft/identity/labapi/utilities/client/LabClient.java
Outdated
Show resolved
Hide resolved
LabApiUtilities/src/main/com/microsoft/identity/labapi/utilities/client/ILabClient.java
Outdated
Show resolved
Hide resolved
LabApiUtilities/src/main/com/microsoft/identity/labapi/utilities/client/ILabClient.java
Outdated
Show resolved
Hide resolved
LabApiUtilities/src/main/com/microsoft/identity/labapi/utilities/client/LabClient.java
Outdated
Show resolved
Hide resolved
LabApiUtilities/src/main/com/microsoft/identity/labapi/utilities/client/LabClient.java
Show resolved
Hide resolved
LabApiUtilities/src/main/com/microsoft/identity/labapi/utilities/client/LabClient.java
Outdated
Show resolved
Hide resolved
LabApiUtilities/src/test/com/microsoft/identity/labapi/utilities/client/LabClientTest.java
Show resolved
Hide resolved
LabApiUtilities/src/main/com/microsoft/identity/labapi/utilities/client/LabClient.java
Outdated
Show resolved
Hide resolved
LabApiUtilities/src/main/com/microsoft/identity/labapi/utilities/client/ILabClient.java
Outdated
Show resolved
Hide resolved
LabApiUtilities/src/main/com/microsoft/identity/labapi/utilities/client/ILabClient.java
Outdated
Show resolved
Hide resolved
mohitc1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
![]()
This PR expands our automation code to enable pulling the upn json string from the MobileBuildVault Key Vault
AB#3478938