Skip to content

Replace valid ID Token cred with a mocked ID Token, Fixes AB#3478931 #2843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
shahzaibj wants to merge 5 commits into
base: dev
Choose a base branch
from
Open

Replace valid ID Token cred with a mocked ID Token, Fixes AB#3478931 #2843

shahzaibj wants to merge 5 commits into from
+1 −1

Conversation

@shahzaibj
Copy link
Contributor

@shahzaibj shahzaibj commented Dec 22, 2025 •
edited
Loading

Fixes AB#3478931

@shahzaibj shahzaibj self-assigned this Dec 22, 2025
@shahzaibj shahzaibj requested a review from a team as a code owner December 22, 2025 19:08
Copilot AI review requested due to automatic review settings December 22, 2025 19:08
@github-actions
Copy link

github-actions bot commented Dec 22, 2025

❌ Work item link check failed. Description does not contain AB#{ID}.

Click here to Learn more.

Copilot AI reviewed Dec 22, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR replaces a realistic-looking JWT ID token in test data with a generic example token, removing potentially sensitive information from the test suite.

Key Changes:

  • Replaced the id_token value in testSignInTokenApiResponseSuccess() with a well-known generic JWT example token (the standard jwt.io "John Doe" token)

@shahzaibj shahzaibj added the No-Changelog This Pull-Request has no associated changelog entry. label Jan 2, 2026
@github-actions github-actions bot changed the title Update NativeAuthResponseHandlerTest.kt Update NativeAuthResponseHandlerTest.kt, Fixes AB#3478931 Jan 5, 2026
@shahzaibj shahzaibj changed the title Update NativeAuthResponseHandlerTest.kt, Fixes AB#3478931 Replace valid ID Token cred with a mocked ID Token Jan 5, 2026
@github-actions github-actions bot changed the title Replace valid ID Token cred with a mocked ID Token Replace valid ID Token cred with a mocked ID Token, Fixes AB#3478931 Jan 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@cacosta33 cacosta33 cacosta33 approved these changes

@melissaahn melissaahn melissaahn approved these changes

+1 more reviewer

@Yuki-YuXin Yuki-YuXin Yuki-YuXin approved these changes

Reviewers whose approvals may not affect merge requirements

At least 2 approving reviews are required to merge this pull request.

Assignees

@shahzaibj shahzaibj

Labels

No-Changelog This Pull-Request has no associated changelog entry.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@shahzaibj @cacosta33 @melissaahn @Yuki-YuXin