Skip to content

Mention licence #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 22, 2020
Merged

Mention licence #76

merged 1 commit into from
Sep 22, 2020

Conversation

rayluo
Copy link
Contributor

@rayluo rayluo commented Sep 17, 2020

Mention license. Also add project_urls which would probably trigger an automatic project home page link being rendered in PyPI. This would fix #75 , although we would only see the result at next release.

…n automatic project home page link being rendered in PyPI
@rayluo rayluo requested a review from abhidnya13 September 17, 2020 20:06
Copy link
Contributor

@abhidnya13 abhidnya13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious, is there a reason we are doing this in setup.cfg and not setup.py ? I was referring to MSAL and I see most of this information is in setup.py except the changelog url.

@rayluo
Copy link
Contributor Author

rayluo commented Sep 18, 2020

Yeah we are tentatively experimenting the setup.cfg approach.

@abhidnya13 abhidnya13 self-requested a review September 22, 2020 19:21
Copy link
Contributor

@abhidnya13 abhidnya13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@rayluo rayluo merged commit 0d47dad into dev Sep 22, 2020
@rayluo rayluo deleted the mention-licensing branch September 22, 2020 20:20
This was referenced Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add license and SCM to setup.py
2 participants