-
Notifications
You must be signed in to change notification settings - Fork 31
Unified exception when load() is called before save() #67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hey Ray, Thanks for getting this perspective, love to see different ways of doing things ! |
Good question! The reason I feel uncomfortable of |
c91e8ac
to
f3df576
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It will be also good to have test cases for the newer usecases in Key chain and keyring that we are handling with the help of this PR
b018b0d
to
07839e4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚢
Hi Abhi, while pondering #65 , I feel uncomfortable of its introduction of a new
None
return value, and today I also realize that such a new behavior in the other 3 persistence flavours are inconsistent withFilePersistence
. So, in this PR, I'm experimenting a different approach, to NOT introduce theNone
as a successful return value, but rather raise exception - this time we raise a commonIOError
. Test cases are not yet added. Please review this proof-of-concept.UPDATE at 8/28: We settled with a new exception
PersistenceNotFound
for the scenario described in #64This PR will replace/close #65, and resolve #64.