Enable PublicApiAnalyzers

[keegan-caruso]

Enable PublicApiAnalyzers

See: https://github.com/dotnet/roslyn-analyzers/blob/main/src/PublicApiAnalyzers/PublicApiAnalyzers.Help.md

Include internals for assemblies that are marked with InternalsVisibleTo

[keegan-caruso]

AzDO is passing but not the github action, interesting.

[jennyf19]

AzDO is passing but not the github action, interesting.

You might try updating the github action from preview 4 to 7 for .NET 9

9.0.100-preview.7.24407.12

[pmaytak]

As we added this mid release, I had to manually adjust shipped vs unshipped using this as reference

What something like this work - checkout the last 8.0.1 commit, run the tool to generate text files, stash them, and move them over to this branch?

How and when are those files generated, especially the for the unshipped API? Does the tool run automatically somehow or manually update the files?

[keegan-caruso]

What something like this work - checkout the last 8.0.1 commit, run the tool to generate text files, stash them, and move them over to this branch?

How and when are those files generated, especially the for the unshipped API? Does the tool run automatically somehow or manually update the files?

These are generated by the fixer with the analyzer. But it doesn't work great for per target items. You can generate it, but then have to manually move it.

I think it should be okay as it. At the next release, we move everything over to released.

[jennyf19]

[keegan-caruso]

As we added this mid release, I had to manually adjust shipped vs unshipped using this as reference

What something like this work - checkout the last 8.0.1 commit, run the tool to generate text files, stash them, and move them over to this branch?

How and when are those files generated, especially the for the unshipped API? Does the tool run automatically somehow or manually update the files?

I ended up going a different route, just start with everything unshipped, on the first release using this, move everything to shipped

[jennyf19]

@keegan-caruso do you want this in?