Skip to content

Using PredicateBuilder class for querying Users and Groups#74

Merged
boscoMW merged 2 commits intoAzureAD:masterfrom
CecilyK:predicatebuildertest
Jan 24, 2022
Merged

Using PredicateBuilder class for querying Users and Groups#74
boscoMW merged 2 commits intoAzureAD:masterfrom
CecilyK:predicatebuildertest

Conversation

@CecilyK
Copy link
Contributor

@CecilyK CecilyK commented Jan 18, 2022

No description provided.

@ghost
Copy link

ghost commented Jan 18, 2022

CLA assistant check
All CLA requirements met.

Copy link
Contributor

@marcusca10 marcusca10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CecilyK just some code cleanup and we're good

}

// LastModified filter
//
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CecilyK could you update this comment, the value should be: //LastModified filter

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done :)

}
else
return Task.FromResult(results.ToArray());
return Task.FromResult((results.ToArray()));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CecilyK clean up the additional parentheses ;)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done :)

{
int count = parameters.PaginationParameters.Count.HasValue ? parameters.PaginationParameters.Count.Value : 0;
return Task.FromResult(results.Take(count).ToArray());
return Task.FromResult((results.Take(count).ToArray()));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CecilyK clean up the additional parentheses ;)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done :)

Copy link
Contributor

@marcusca10 marcusca10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Copy link
Collaborator

@boscoMW boscoMW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@boscoMW boscoMW merged commit 0c0ac68 into AzureAD:master Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants