Support group membership removal when value is inlined with the Path.#25
Merged
ArvindHarinder1 merged 2 commits intomasterfrom May 5, 2020
Merged
Conversation
Collaborator
ankitC
commented
May 5, 2020
ankitC
commented
- When the group membership to be removed is inlined in the path, it is now removed correctly from the group.
- Members already part of the group cannot be re-added to the group.
- Patching of the extension attribute used to fail if the user was not created using the extension attribute. That has been fixed.
- Sundry formatting changes and fixes.
1. When the group membership to be removed is inlined in the path, it is now removed correctly from the group. 2. Members already part of the group cannot be re-added to the group. 3. Patching of the extension attribute used to fail if the user was not created using the extension attribute. That has been fixed. 4. Sundry formatting changes and fixes.
marcusca10
added a commit
that referenced
this pull request
Nov 10, 2020
* Fixed build warnings * Add files via upload * Multiple issues addressed. (#25) 1. When the group membership to be removed is inlined in the path, it is now removed correctly from the group. 2. Members already part of the group cannot be re-added to the group. 3. Patching of the extension attribute used to fail if the user was not created using the extension attribute. That has been fixed. 4. Sundry formatting changes and fixes. * Get ResourceTypes test condition (#26) * Get ResourceTypes test condition * fix Post enterprise user test, user enterprise schema for department Co-authored-by: Plamen Stoyanov <plamens@knowbe4.com> * Update README.md * Added support for Custom Protocol (#33) Signed-off-by: Dan Elkis <dan@monday.com> Co-authored-by: RyanE <v-ryeaki@microsoft.com> Co-authored-by: ArvindHarinder1 <36525136+ArvindHarinder1@users.noreply.github.com> Co-authored-by: Ankit K Chheda <ankitC@users.noreply.github.com> Co-authored-by: plamenGo <plamen25@gmail.com> Co-authored-by: Plamen Stoyanov <plamens@knowbe4.com> Co-authored-by: Dan Elkis <speakupness@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.