Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation changes #31

Merged
merged 6 commits into from
May 28, 2020
Merged

Documentation changes #31

merged 6 commits into from
May 28, 2020

Conversation

harshitha1112
Copy link
Contributor

No description provided.

@msftclas
Copy link

msftclas commented Apr 23, 2020

CLA assistant check
All CLA requirements met.

@harshitha1112 harshitha1112 marked this pull request as draft April 23, 2020 05:07
@harshitha1112 harshitha1112 marked this pull request as ready for review April 23, 2020 05:07
@harshitha1112 harshitha1112 marked this pull request as draft April 23, 2020 05:11
@eaarora-ms
Copy link
Contributor

@harshitha1112 The PR status shows that it is in the draft stage. Can you please confirm if it is ready to review?

README.md Outdated
Note: Workflow samples with sample application code and deployment procedure for various **runtime** environments are given at (https://github.com/Azure/actions-workflow-samples/tree/master/AppService).
For Eg: If You want to deploy a Java WAR based app, You can follow the link https://github.com/Azure-Samples/Java-application-petstore-ee7 in the sample workflow templates.

1. Create a web app on Azure app service. Follow the tutorial [Azure Web Apps Quickstart](https://docs.microsoft.com/en-us/azure/app-service/overview#next-steps).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be "Create a web app in Azure."

@eaarora-ms
Copy link
Contributor

eaarora-ms commented May 14, 2020

@harshitha1112 This looks good to me. Thanks for your contribution. Please make the changes I suggested and tag me to approve the PR once you are ready to merge.

@N-Usha Can you also please take a look at this?

@eaarora-ms eaarora-ms requested a review from N-Usha May 14, 2020 06:02
@eaarora-ms eaarora-ms self-assigned this May 14, 2020
@harshitha1112 harshitha1112 marked this pull request as ready for review May 24, 2020 07:00
@N-Usha N-Usha merged commit 28ffdfe into Azure:master May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants