Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to Trusted Signing module 0.4.1 #38

Merged
merged 6 commits into from
Jul 17, 2024
Merged

Update to Trusted Signing module 0.4.1 #38

merged 6 commits into from
Jul 17, 2024

Conversation

japarson
Copy link
Collaborator

  • Add general logging messages to help with debugging
  • Add support for new Files input
  • Add support for wildcards when using file filters
  • Refactor dependency installation to check for existing packages before calling Get-NugetV2PackageSource
    (perf)

Closes #26 #16 #9

@japarson japarson requested a review from a team as a code owner June 20, 2024 05:14
riverar
riverar suggested changes Jul 4, 2024
View reviewed changes
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
BretJohnson
BretJohnson reviewed Jul 17, 2024
View reviewed changes
README.md Show resolved Hide resolved
BretJohnson
BretJohnson previously approved these changes Jul 17, 2024
View reviewed changes
Copy link

@BretJohnson BretJohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments above to consider. But otherwise LGTM.

@japarson japarson merged commit 9b24fb5 into main Jul 17, 2024
1 check passed
@japarson japarson deleted the dev/japarson/catalog-docs branch July 17, 2024 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@riverar riverar riverar requested changes

@anchimna anchimna anchimna approved these changes

@BretJohnson BretJohnson BretJohnson left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add extra option to the Powershell module and this action to filter the files that need to be signed.
4 participants
@japarson @BretJohnson @riverar @anchimna