This repository has been archived by the owner on Oct 7, 2024. It is now read-only.
Add variable for tags #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zioproto
reviewed
Oct 9, 2023
| @@ -6,10 +6,10 @@ resource "random_integer" "this" { | |||
| locals { | |||
| account_name = coalesce(var.account_name, "azure-openai-${random_integer.this.result}") | |||
| custom_subdomain_name = coalesce(var.custom_subdomain_name, "azure-openai-${random_integer.this.result}") | |||
| tags = var.default_tags_enabled ? { | |||
| tags = merge(var.default_tags_enabled ? { | |||
There was a problem hiding this comment.
@soferreira do we want to give the possibility to add additional tags also when the default tags are enabled ? Or this version of the logic works ?
@JinLee794 feedback is welcome
There was a problem hiding this comment.
Ah wait, I misunderstood the code.
I understand now correctly that var.tags is always merged in the tags, regarless of the value of var.default_tags_enabled.
Looks good to me !
zioproto
approved these changes
Oct 9, 2023
soferreira
approved these changes
Oct 9, 2023
zioproto
added a commit
that referenced
this pull request
Oct 16, 2023
Merged
zioproto
added a commit
that referenced
this pull request
Oct 16, 2023
zioproto
added a commit
that referenced
this pull request
Oct 16, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Issue number
#35
Checklist before requesting a review
CHANGELOG.mdfileThanks for your cooperation!