pushing for merge with the official repo #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sblack4
approved these changes
Jan 31, 2020
| @@ -0,0 +1,18 @@ | |||
| # Pull the base image with given version. | |||
| ARG BUILD_TERRAFORM_VERSION=0.11.7 | |||
| FROM microsoft/terraform-test:${BUILD_TERRAFORM_VERSION} | |||
There was a problem hiding this comment.
Terraform v12 is so hot right now. Here's another Azure PR to upgrade the test dockerfile https://github.com/Azure/terraform-azurerm-aks/pull/35/files
I don't mind doing the upgrade in a subsequent PR
| MIT License | ||
|
|
||
| Copyright (c) Microsoft Corporation. All rights reserved. | ||
| Copyright (c) 2019 Guilherme Lucas |
There was a problem hiding this comment.
I'm guessing Microsoft is going to have a problem with this changing of the license but idk
|
|
||
| output "db_name" { | ||
| value = "${azurerm_mariadb_database.mariadb_database.name}" | ||
| } No newline at end of file |
There was a problem hiding this comment.
This file could really use formatting - terraform fmt
|
@jcorioland @WodansSon is Azure still interested in terraform modules? |
|
Any chance anyone is merging this? I would be more than happy to make the changes you asked @sblack4 ! Just wanted to know! |
|
@grayzu could you help @Guilhermeslucas to get this merged, please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello everyone, Im creating this PR in order to merge the module I created during the Terraform Bug Bash!
Best regards!