Skip to content

Conversation

@anson627
Copy link
Collaborator

@anson627 anson627 commented Jan 2, 2026

This pull request makes targeted updates to the fio deployment configuration and the fio benchmark execution script. The main changes are a modification to the mount path used by the fio container and the addition of an option to the fio command to ensure test files are cleaned up after execution.

Deployment configuration update:

  • Changed the mountPath for the fio container from /mnt/nvme-raid to /mnt/data in volumes.yaml to reflect the correct storage location.

Fio benchmark execution improvement:

  • Added the --unlink=1 option to the fio command in fio.py to automatically remove test files after the benchmark completes, helping to keep the storage clean.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR standardizes the fio container mount path and adds automatic cleanup of test files. The changes ensure consistency across different storage overlay configurations and improve storage hygiene by removing test files after benchmarks complete.

  • Updated the container mount path from /mnt/nvme-raid to /mnt/data to align with other fio storage overlays
  • Added the --unlink=1 flag to the fio command to automatically delete test files after benchmark execution

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
modules/python/fio/fio.py Added --unlink=1 flag to fio command arguments to enable automatic cleanup of test files after benchmark completion
modules/kustomize/fio/overlays/local-hostpath/deployment/volumes.yaml Changed container mountPath from /mnt/nvme-raid to /mnt/data to standardize with other storage overlays (acstor-v2, os-disk, zfs-localpv)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants