Update node retrieval logic to ensure only ready and schedulable node… #990
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s are used for fio jobs
anson627
requested review from
sumanthreddy29,
vittoriasalim,
wonderyl and
xinWeiWei24
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves node selection for FIO jobs by ensuring only ready and schedulable nodes are used. The change upgrades from basic node listing to a more robust selection that validates node health and schedulability.
- Updated node retrieval to use
get_ready_nodesinstead ofget_nodes - Enhanced error message to clarify the requirement for ready and schedulable nodes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes a minor improvement to how nodes are selected for FIO jobs. Instead of selecting any node with the label
fio-dedicated=true, it now specifically selects only nodes that are ready and schedulable, and updates the error message accordingly.executeinfio.pyto useget_ready_nodesinstead ofget_nodes, ensuring only ready and schedulable nodes with thefio-dedicated=truelabel are used. The error message was also updated to clarify this requirement.…s are used for fio jobs