fix: update GKE cluster name formatting to ensure proper length and s… #989
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anson627
requested review from
alyssa1303,
sumanthreddy29,
vittoriasalim,
wonderyl and
xinWeiWei24
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request updates the GKE cluster name generation logic to use a simpler substring and trim approach instead of regex-based extraction, ensuring cluster names stay within GCP's 40-character limit and don't end with hyphens.
- Replaced regex-based
run_idextraction with fullrun_idusage and length truncation - Applied
trimrightto remove trailing hyphens after substring truncation
anson627
force-pushed
the
fix-gke-cluster-name
branch
from
d245d8f to
b5d418f
Compare
anson627
force-pushed
the
fix-gke-cluster-name
branch
from
b5d418f to
4278a14
Compare
sumanthreddy29
approved these changes
Jan 7, 2026
xgugeng
pushed a commit
that referenced
this pull request
Jan 8, 2026
#989) This pull request updates the way the GKE cluster name is generated in the Terraform configuration to ensure it fits within GCP's naming constraints and is more predictable. Resource naming improvement: * Changed the `name` attribute of the `google_container_cluster.gke` resource to use `trimright(substr(..., 0, 40), "-")` instead of a regex-based approach, ensuring the cluster name is always at most 40 characters and does not end with a hyphen.…tructure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the way the GKE cluster name is generated in the Terraform configuration to ensure it fits within GCP's naming constraints and is more predictable.
Resource naming improvement:
nameattribute of thegoogle_container_cluster.gkeresource to usetrimright(substr(..., 0, 40), "-")instead of a regex-based approach, ensuring the cluster name is always at most 40 characters and does not end with a hyphen.…tructure