Skip to content

Refactor KWOK node creation script for improved readability #988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anson627 merged 3 commits into from
Jan 6, 2026
+10 −6
Merged

Refactor KWOK node creation script for improved readability #988

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a280dce
Refactor KWOK node creation script for improved readability
anson627 Dec 23, 2025
76dd1da
Merge branch 'main' into fix-kwok-validate-resources
anson627 Jan 6, 2026
be67543
Merge branch 'main' into fix-kwok-validate-resources
anson627 Jan 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions steps/topology/kwok/validate-resources.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,14 +24,18 @@ steps:
- script: |
set -eo pipefail

CMD="PYTHONPATH=$PYTHONPATH:$(pwd) python3 $KWOK_SCRIPT_FILE"
CMD="$CMD --action create"
CMD="$CMD --node-count $NODE_COUNT"
CMD="$CMD --node-gpu ${NODE_GPU:-\"0\"}"
if [ "$ENABLE_DRA" = "True" ]; then
CMD="$CMD --enable-dra"
PYTHONPATH=$PYTHONPATH:$(pwd) python3 $KWOK_SCRIPT_FILE \
--action create \
--node-count $NODE_COUNT \
--node-gpu ${NODE_GPU:-"0"} \
--enable-dra
else
PYTHONPATH=$PYTHONPATH:$(pwd) python3 $KWOK_SCRIPT_FILE \
--action create \
--node-count $NODE_COUNT \
--node-gpu ${NODE_GPU:-"0"}
fi
eval $CMD

workingDirectory: modules/python
env:
Expand Down