Skip to content

Conversation

@anson627
Copy link
Collaborator

This pull request updates the default path for the job template used by the job controller in ClusterLoader2 from job_template.yaml to base/job_template.yaml. This ensures consistency across the configuration, command-line arguments, and execution steps.

Configuration and Defaults:

  • Changed the default value of job_template_path in the config.yaml file to base/job_template.yaml to reflect the new location of the job template.

Command-Line Arguments:

  • Updated the default value for the --job_template_path argument in job_controller.py to base/job_template.yaml.

Execution Scripts:

  • Modified the execution step in execute.yml to use base/job_template.yaml as the default for the JOB_TEMPLATE_PATH environment variable.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request updates the default job template path from job_template.yaml to base/job_template.yaml across the ClusterLoader2 job controller configuration. This change aligns the default values with the actual location of the base job template file and matches the explicit paths already being used in pipeline configurations.

Key Changes:

  • Updated the default value in the YAML configuration template
  • Updated the command-line argument default in the configure subparser
  • Updated the shell script default in the execution step

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
modules/python/clusterloader2/job_controller/config/config.yaml Changed default template path parameter to base/job_template.yaml
modules/python/clusterloader2/job_controller/job_controller.py Updated configure subparser's --job_template_path default to base/job_template.yaml
steps/engine/clusterloader2/job_controller/execute.yml Updated bash script default for JOB_TEMPLATE_PATH environment variable to base/job_template.yaml

@anson627 anson627 merged commit 65db35e into main Jan 6, 2026
8 of 10 checks passed
@anson627 anson627 deleted the fix-default-job-template branch January 6, 2026 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants