-
Notifications
You must be signed in to change notification settings - Fork 18
feat: add Node Auto Provisioning Benchmark in STLS Bootstrap Suite #960
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds infrastructure configuration files for the stls-bootstrap-nap test scenario, which combines Secure TLS Bootstrapping with Node Auto Provisioning (NAP/Karpenter) testing. The scenario is referenced by an existing pipeline file (pipelines/perf-eval/Secure TLS Bootstrap Benchmark/node-auto-provisioning.yml) and these files provide the necessary Terraform and Kubernetes configurations.
- Adds terraform test inputs for Azure with westus2 region configuration
- Adds terraform configuration enabling Secure TLS Bootstrapping feature with NAP mode
- Adds Karpenter NodePool definitions for both on-demand and spot instances
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| scenarios/perf-eval/stls-bootstrap-nap/terraform-test-inputs/azure.json | Adds test input JSON with run_id and westus2 region for terraform validation |
| scenarios/perf-eval/stls-bootstrap-nap/terraform-inputs/azure.tfvars | Adds terraform variables configuring AKS with Secure TLS Bootstrapping and Node Auto Provisioning mode |
| scenarios/perf-eval/stls-bootstrap-nap/kubernetes/karpenter_nodepool.azure.yml | Adds Karpenter NodePool and AKSNodeClass definitions for on-demand and spot workloads |
f29eba2 to
1018b3c
Compare
cameronmeissner
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
confirmed Karpenter is using secure TLS bootstrapping within these tests
Adding a NAP test for the STLS benchmark suite. This is mostly 1:1 with the standard NAP test but adds the STLS custom header and MC tag to enable the feature.
Includes a small change to aks-cli in order to allow setting custom MC tags.