Skip to content

Conversation

@KananMehta
Copy link
Contributor

@KananMehta KananMehta commented Dec 5, 2025

Adding a NAP test for the STLS benchmark suite. This is mostly 1:1 with the standard NAP test but adds the STLS custom header and MC tag to enable the feature.

Includes a small change to aks-cli in order to allow setting custom MC tags.

@KananMehta KananMehta marked this pull request as ready for review December 5, 2025 20:10
Copilot AI review requested due to automatic review settings December 5, 2025 20:10
@KananMehta KananMehta changed the title Kananmehta/add naptest Add Node Auto Provisioning Benchmark in STLS Bootstrap Suite Dec 5, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds infrastructure configuration files for the stls-bootstrap-nap test scenario, which combines Secure TLS Bootstrapping with Node Auto Provisioning (NAP/Karpenter) testing. The scenario is referenced by an existing pipeline file (pipelines/perf-eval/Secure TLS Bootstrap Benchmark/node-auto-provisioning.yml) and these files provide the necessary Terraform and Kubernetes configurations.

  • Adds terraform test inputs for Azure with westus2 region configuration
  • Adds terraform configuration enabling Secure TLS Bootstrapping feature with NAP mode
  • Adds Karpenter NodePool definitions for both on-demand and spot instances

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
scenarios/perf-eval/stls-bootstrap-nap/terraform-test-inputs/azure.json Adds test input JSON with run_id and westus2 region for terraform validation
scenarios/perf-eval/stls-bootstrap-nap/terraform-inputs/azure.tfvars Adds terraform variables configuring AKS with Secure TLS Bootstrapping and Node Auto Provisioning mode
scenarios/perf-eval/stls-bootstrap-nap/kubernetes/karpenter_nodepool.azure.yml Adds Karpenter NodePool and AKSNodeClass definitions for on-demand and spot workloads

@KananMehta KananMehta force-pushed the kananmehta/add-naptest branch from f29eba2 to 1018b3c Compare January 5, 2026 21:18
@KananMehta KananMehta changed the title Add Node Auto Provisioning Benchmark in STLS Bootstrap Suite feat: add Node Auto Provisioning Benchmark in STLS Bootstrap Suite Jan 8, 2026
Copy link

@cameronmeissner cameronmeissner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

confirmed Karpenter is using secure TLS bootstrapping within these tests

@KananMehta KananMehta merged commit 8254b51 into main Jan 10, 2026
53 checks passed
@KananMehta KananMehta deleted the kananmehta/add-naptest branch January 10, 2026 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants