fix: add job_template_path parameter to collect results script #1006
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anson627
requested review from
alyssa1303,
sumanthreddy29,
vittoriasalim,
wonderyl and
xinWeiWei24
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for specifying a custom job template path in the ClusterLoader2 job controller's result collection step. The change enables users to override the default job template by setting the JOB_TEMPLATE_PATH environment variable, while falling back to base/job_template.yaml if not specified.
- Adds
--job_template_pathparameter to the collect results script with bash parameter expansion for flexible configuration - Aligns the collect step with the execute step, which already supports this parameter
sumanthreddy29
approved these changes
Jan 7, 2026
xgugeng
pushed a commit
that referenced
this pull request
Jan 8, 2026
This pull request makes a small update to the job configuration by adding support for specifying a custom job template path. This change allows for more flexibility in job submissions by letting users override the default job template. * Added a `--job_template_path` parameter to the job controller step in `steps/engine/clusterloader2/job_controller/collect.yml`, defaulting to `base/job_template.yaml` if not specified.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes a small update to the job configuration by adding support for specifying a custom job template path. This change allows for more flexibility in job submissions by letting users override the default job template.
--job_template_pathparameter to the job controller step insteps/engine/clusterloader2/job_controller/collect.yml, defaulting tobase/job_template.yamlif not specified.