feat: enable karpenter ms complex config , make parameter to be configurable #1004
+167
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vittoriasalim
requested review from
alyssa1303,
anson627,
sumanthreddy29,
wonderyl and
xinWeiWei24
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enables flexible Karpenter configuration for Microsoft complex scenarios by making VM size optional and allowing the Karpenter nodepool file to be configurable. It adds a new complex nodepool configuration for Azure and includes comprehensive pipeline schedule documentation.
- Adds
karpenter_nodepool_fileparameter to allow custom nodepool configurations - Makes VM_SIZE patching conditional (only when VM_SIZE is provided)
- Introduces a new complex nodepool configuration with multiple VM sizes and a system-surge pool
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| steps/topology/karpenter/validate-resources.yml | Adds new parameter for configurable nodepool file and makes VM size patching conditional |
| scenarios/perf-eval/nap/kubernetes/karpenter_complex_nodepool.azure.yml | New complex Karpenter nodepool configuration with multiple VM sizes and three nodepools (default, spot, system-surge) |
| PIPELINE_SCHEDULES.md | New documentation file providing comprehensive overview of all pipeline schedules (appears unrelated to main PR purpose) |
added 2 commits
January 6, 2026 21:41
xinWeiWei24
previously approved these changes
Jan 7, 2026
added 2 commits
January 8, 2026 11:43
vittoriasalim
force-pushed
the
vitto/karpenter_refactor
branch
from
e723445 to
2d7d2ac
Compare
added 2 commits
January 8, 2026 14:12
xinWeiWei24
approved these changes
Jan 8, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make vm size as optional # if not specified, do not patch
make karpenter nodepool file to be configurable/adjustable