Skip to content

[submodule] Update SAI to v1.15.3#1

Merged
r12f merged 1 commit into
Azure:202412from
r12f:user/r12f/update-sai
Jan 11, 2025
Merged

[submodule] Update SAI to v1.15.3#1
r12f merged 1 commit into
Azure:202412from
r12f:user/r12f/update-sai

Conversation

@r12f
Copy link
Copy Markdown
Contributor

@r12f r12f commented Jan 8, 2025

Update to most recent SAI v.15 release.

Signed-off-by: r12f <r12f.code@gmail.com>
@liushilongbuaa
Copy link
Copy Markdown
Contributor

/azp run

@liushilongbuaa
Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@liushilongbuaa
Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines
Copy link
Copy Markdown

Commenter does not have sufficient privileges for PR 1 in repo Azure/sonic-sairedis.msft

@r12f
Copy link
Copy Markdown
Contributor Author

r12f commented Jan 11, 2025

CI passed on regular SAI redis with the same commit history:

image

@r12f r12f merged commit ded75e1 into Azure:202412 Jan 11, 2025
@r12f r12f deleted the user/r12f/update-sai branch January 11, 2025 01:05
mssonicbld added a commit that referenced this pull request Apr 30, 2026
<!--
Please make sure you've read and understood our contributing guidelines;
https://github.com/Azure/SONiC/blob/gh-pages/CONTRIBUTING.md

Please provide following information to help code review process a bit easier:
-->
### Description of PR
<!--
- Please include a summary of the change and which issue is fixed.
- Please also include relevant motivation and context. Where should reviewer start? background context?
- List any dependencies that are required for this change.
-->

Summary:
Fixes a race condition during init_switch causing syncd crash

### Type of change

<!--
- Fill x for your type of change.
- e.g.
- [x] Bug fix
-->

- [x] Bug fix
- [ ] New feature
- [ ] Refactor / cleanup
- [ ] Documentation update
- [ ] Test improvement

### Approach
#### What is the motivation for this PR?
We saw below core dump during init_switch.
```
#0 0x0000ffffb5c369d0 in vpp_ev_enqueue (ev=0xaaaabe182c50) at vpp/vppxlate/SaiVppXlate.c:397
#1 vl_api_sw_interface_event_t_handler (mp=<optimized out>) at vpp/vppxlate/SaiVppXlate.c:687
#2 0x0000ffffb5264470 in vl_msg_api_handler_no_free ()
 from /nobackup/yuega2/sonic-buildimage-cisco.202603.arctos-periodic-40135/syncd_dbg/rootfs/lib/aarch64-linux-gnu/libvlibapi.so.25.02.0
#3 0x0000ffffb5205648 in ?? ()
 from /nobackup/yuega2/sonic-buildimage-cisco.202603.arctos-periodic-40135/syncd_dbg/rootfs/lib/aarch64-linux-gnu/libvlibmemoryclient.so.25.02.0
#4 0x0000ffffb5c3cd54 in vpp_intf_events_enable_disable (enable=true) at vpp/vppxlate/SaiVppXlate.c:1839
#5 init_vpp_client () at vpp/vppxlate/SaiVppXlate.c:1704
#6 0x0000ffffb5c208bc in saivs::SwitchVpp::vpp_dp_initialize (this=this@entry=0xaaaabe17a3d0) at vpp/SwitchVppRif.cpp:468
#7 0x0000ffffb5c0508c in saivs::SwitchVpp::SwitchVpp (this=this@entry=0xaaaabe17a3d0, switch_id=switch_id@entry=141733920768, manager=..., config=...,
 warmBootState=...) at vpp/SwitchVpp.cpp:44
```
This happened during init_switch right after vpp_intf_events_enable_disable, an event came in but event_queue had not been properly initialized.
##### Work item tracking
- Microsoft ADO **(number only)**:

#### How did you do it?
Move event queue initialization before enabling events from vpp.

#### How did you verify/test it?
Run sonic-mgmt via sonic-net/sonic-buildimage#27039
#### Any platform specific information?
vpp specific
### Documentation
<!--
(If it's a new feature, new test case)
Did you update documentation/Wiki relevant to your implementation?
Link to the wiki page?
-->

Signed-off-by: Sonic Build Admin <sonicbld@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants