Minor fixes to toward move to GA#153
Conversation
tsubasaxZZZ
changed the title
| "storage_workbook_resource_id" = azurerm_application_insights_workbook.storage[0].id | ||
| "web_workbook_resource_id" = azurerm_application_insights_workbook.web[0].id | ||
| "servicealert_workbook_resource_id" = azurerm_application_insights_workbook.servicealert[0].id | ||
| "resiliencyscenarios_workbook_resource_id" = azurerm_application_insights_workbook.resiliencyscenarios[0].id |
There was a problem hiding this comment.
It is better to rename this to something similar to "resiliencyscenario_crossregion" or "crrResiliencyScenario" because there might be new workbooks supporting other resiliency scenarios in future. Feel free to use your own name but should be able to include additional resiliency scenarios without renaming this workbook name.
| (type == 'microsoft.web/serverfarms'), iff(properties.zoneRedundant == 'true', 'Configured', 'Not Configured'), | ||
| (type == 'microsoft.sql/servers/databases' and sku.tier <> 'DataWarehouse'), case( //SQL AZ SKU & region availability filter | ||
| sku.name == 'Basic' or sku.name == 'Standard' or sku.name == 'System', 'Not Applicable', | ||
| sku.name == 'GeneralPurpose' and location !in~ ('westeurope', 'northeurope', 'westus2', 'francecentral', 'eastus', 'eastus2', 'southeastasia', 'qatarcentral', 'australiaeast', 'japaneast', 'uksouth'), 'Not Applicable', |
There was a problem hiding this comment.
Need to ensure whether we validate the regions supported for GP tier: https://learn.microsoft.com/en-us/azure/reliability/migrate-sql-database?tabs=portal#prerequisites
There was a problem hiding this comment.
I updated about this in this commit.
ac51f7b
There was a problem hiding this comment.
Rename the variables, file names, etc. to make it specific to cross region scenario. There might be new scenarios in the future, so we need to make it modularize and extensible without touching this file.
There was a problem hiding this comment.
If a new scenario is created under 'Resiliency scenario', a glue template is created as in the other tabs, which remains flexible.
Therefore, the meaning of "resiliencyscenario" in this commit will remain the same, even if additional workbooks are added under it in the future.
| "storage_workbook_resource_id" = "community-Workbooks/Azure Advisor/Reliability/Storage" | ||
| "web_workbook_resource_id" = "community-Workbooks/Azure Advisor/Reliability/Web" | ||
| "servicealert_workbook_resource_id" = "community-Workbooks/Azure Advisor/Reliability/ServiceAlert" | ||
| "resiliencyscenarios_workbook_resource_id" = "community-Workbooks/Azure Advisor/Reliability/ResiliencyScenarios" |
There was a problem hiding this comment.
Since the environment folder is mainly to create the test data for the workbook, can we exclude it from the repo (part of .gitignore)?
or at least make it clear that it is for test env and by default it skips the creation and can be enabled with a flag value set.
2 participants
Uh oh!
There was an error while loading. Please reload this page.